From owner-freebsd-java@freebsd.org Sat May 27 23:37:11 2017 Return-Path: Delivered-To: freebsd-java@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 259CDD8473C for ; Sat, 27 May 2017 23:37:11 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 11D321CA5 for ; Sat, 27 May 2017 23:37:11 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: by mailman.ysv.freebsd.org (Postfix) id 0E5FAD8473A; Sat, 27 May 2017 23:37:11 +0000 (UTC) Delivered-To: java@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C576D84739 for ; Sat, 27 May 2017 23:37:11 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D1E4D1CA4 for ; Sat, 27 May 2017 23:37:10 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (localhost [127.0.0.1]) by ainaz.pair.com (Postfix) with ESMTP id 627E83F5E3; Sat, 27 May 2017 19:37:09 -0400 (EDT) Received: from anthias.dhcp.nue.suse.com (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ainaz.pair.com (Postfix) with ESMTPSA id ED01E3F5DF; Sat, 27 May 2017 19:37:08 -0400 (EDT) Date: Sun, 28 May 2017 01:37:07 +0200 (CEST) From: Gerald Pfeifer To: Joe Nosay , java@freebsd.org Subject: Re: Remove dead code from java/cacao/Makefile In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 May 2017 23:37:11 -0000 Hi Joe, and thanks for the detailed response. On Sun, 14 May 2017, Joe Nosay wrote: >> Okay to apply? > Do not remove that option. There are other java kits and code that is > open source. There was and should still be a Java JIT application with > llvm/CLang. I did not propose to remove that option, I merely wanted to relay that (a) currently this alternative codepath is simply broken and (b) remove three lines of dead code at least. > Just comment the option so that it is not used. > Use IceTea in the bootstrap. > You will need to create and recreate all of the open non-propritary > libraries, binaries, links, suites, and applications this way. > Bootstrap and create the path layouts according to the same $PATH and > $CLASSPATH of the standard Oracle-Sun Java Development Environment. > > Save everything. > Set this up as a script. > Make a complete package. > Submit what you have done > to: info@freebsd.org as an email That's a lot more than I'm up to, I'm afraid. However, the patch below still makes sense and removes dead code. Okay to apply this? (Another change to bring this closer to even have a chance of working is adjusting GCC_SUFX?=46 to GCC_SUFX?=5. I can guarantee that 46 has zero chance of working, even theoretically.) But, one thing at a time. Can you, or someone else, please approve the three-liner below to simplify this? Gerald Index: java/cacao/Makefile =================================================================== --- java/cacao/Makefile (revision 441883) +++ java/cacao/Makefile (working copy) @@ -36,9 +36,6 @@ JAR= ${LOCALBASE}/bootstrap-openjdk/bin/jar JAVAC= ${LOCALBASE}/bootstrap-openjdk/bin/javac .else -.if defined(WITH_GCC) -GCC_SUFX= ${WITH_GCC:S/.//} -.endif GCC_SUFX?= 46 BUILD_DEPENDS+= gcj${GCC_SUFX}:lang/gcc${GCC_SUFX} EXTRA_PATCHES= ${FILESDIR}/gcj.patch