From owner-freebsd-gnome@FreeBSD.ORG  Sun Jun  1 17:26:48 2014
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: gnome@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6C74F2D7;
 Sun,  1 Jun 2014 17:26:48 +0000 (UTC)
Received: from fep12.mx.upcmail.net (fep12.mx.upcmail.net [62.179.121.32])
 by mx1.freebsd.org (Postfix) with ESMTP id 846612F89;
 Sun,  1 Jun 2014 17:26:46 +0000 (UTC)
Received: from edge04.upcmail.net ([192.168.13.239]) by viefep17-int.chello.at
 (InterMail vM.8.01.05.05 201-2260-151-110-20120111) with ESMTP
 id <20140601172534.MNMK4787.viefep17-int.chello.at@edge04.upcmail.net>;
 Sun, 1 Jun 2014 19:25:34 +0200
Received: from [127.0.0.1] ([95.96.229.21]) by edge04.upcmail.net with edge
 id 95RZ1o01K0ULilr035RZev; Sun, 01 Jun 2014 19:25:34 +0200
X-SourceIP: 95.96.229.21
Message-ID: <538B61FF.7070305@rainbow-runner.nl>
Date: Sun, 01 Jun 2014 19:25:19 +0200
From: Koop Mast <kwm@rainbow-runner.nl>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>, gnome@FreeBSD.org
Subject: Re: [patch] devel/glib20: fix crash in multimedia/vlc
References: <20140601182817.5c68df56@kalimero.tijl.coosemans.org>
In-Reply-To: <20140601182817.5c68df56@kalimero.tijl.coosemans.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Antivirus: avast! (VPS 140601-1, 01-06-2014), Outbound message
X-Antivirus-Status: Clean
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
 <freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-gnome>,
 <mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome/>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
 <mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Jun 2014 17:26:48 -0000

On 1-6-2014 18:28, Tijl Coosemans wrote:
> Hi,
>
> The attached patch fixes these PRs for multimedia/vlc (all duplicates):
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/172185
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/183683
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/186629
>
> The vlc-cache-gen program dlopens each plugin, looks for some symbols
> (like a description string), stores that into a cache file and then
> dlcloses the plugin.  For some combinations of options this causes
> libgobject to be loaded, unloaded and then loaded again (as a dependency
> of some plugins).  This is not supported.  See:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=707298
> https://git.gnome.org/browse/glib/commit/?h=glib-2-40&id=3662eb9759fe225d1c214db6927c667a1b733e8a
>
> The attached patch has been derived from that commit.  It adds
> -Wl,-z,nodelete to the libgobject linker flags.
>
> Ok to commit?
>

Yes go ahead.