From owner-freebsd-fs@FreeBSD.ORG Mon Jan 3 02:45:42 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A3F0106564A for ; Mon, 3 Jan 2011 02:45:42 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id CC8AA8FC14 for ; Mon, 3 Jan 2011 02:45:41 +0000 (UTC) Received: (qmail 32409 invoked by uid 399); 3 Jan 2011 02:45:39 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Jan 2011 02:45:39 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4D213852.40608@FreeBSD.org> Date: Sun, 02 Jan 2011 18:45:38 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101210 Thunderbird/3.1.7 MIME-Version: 1.0 To: freebsd-fs@FreeBSD.org X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Pedro F. Giffuni" Subject: ext2fs: PR 153584, prealloc, etc. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 02:45:42 -0000 Howdy, Pedro, Thanks for http://www.freebsd.org/cgi/query-pr.cgi?pr=153584 however it does not compile on HEAD: cc -O2 -pipe -g -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include /usr/local/obj/home/svn/head/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -g -fno-omit-frame-pointer -I/usr/local/obj/home/svn/head/sys/GENERIC -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c: In function 'ext2_checkoverlap': /home/svn/head/sys/modules/ext2fs/../../fs/ext2fs/ext2_subr.c:108: error: dereferencing pointer to incomplete type *** Error code 1 Stop in /home/svn/head/sys/modules/ext2fs. *** Error code 1 I also notice that your work does not seem to include the preallocation work of Aditya, which I've been running ever since the thread in November and has been working well for me. http://lists.freebsd.org/pipermail/freebsd-fs/2010-November/010024.html Any chance you 2 could work together to come up with 1 patch that has the best of both worlds, and actually compiles on HEAD? It would also be really useful if the resultant patch was created using 'svn diff' as it would be a lot easier for those of us who are interested in testing this to do so, not to mention actually getting it committed. Thanks, Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/