Date: Fri, 22 Jan 2016 09:52:17 -0800 From: hiren panchasara <hiren@strugglingcoder.info> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: George Neville-Neil <gnn@neville-neil.com>, Lawrence Stewart <lstewart@freebsd.org>, Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r294535 - in head/sys/netinet: . cc tcp_stacks Message-ID: <20160122175217.GR33895@strugglingcoder.info> In-Reply-To: <C87E7DC6-C9E6-48AC-86C0-BE75972A271D@FreeBSD.org> References: <201601212234.u0LMYpKT009948@repo.freebsd.org> <56A1D6B2.1010406@freebsd.org> <058BD5D5-C1AC-45DA-B6BE-2EDC4D64F67F@neville-neil.com> <C87E7DC6-C9E6-48AC-86C0-BE75972A271D@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--vvRocJ6whMXXNc9q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 01/22/16 at 04:06P, Bjoern A. Zeeb wrote: >=20 > > On 22 Jan 2016, at 15:21 , George Neville-Neil <gnn@neville-neil.com> w= rote: > >=20 > >=20 > >=20 > > On 22 Jan 2016, at 2:13, Lawrence Stewart wrote: > >=20 > >> Hi Gleb, > >>=20 > >> On 01/22/16 09:34, Gleb Smirnoff wrote: > >>> Author: glebius > >>> Date: Thu Jan 21 22:34:51 2016 > >>> New Revision: 294535 > >>> URL: https://svnweb.freebsd.org/changeset/base/294535 > >>>=20 > >>> Log: > >>> - Rename cc.h to more meaningful tcp_cc.h. > >>=20 > >> As a bit of historical context, the naming was intentionally protocol > >> agnostic because it was originally hoped that the CC framework could be > >> shared between multiple CC aware transports, and the design went to so= me > >> lengths to accommodate that possibility (e.g. the ccv_container union = in > >> struct cc_var). SCTP was the obvious potential in tree consumer at the > >> time, and other protocols like DCCP were considered as well. > >>=20 > >> This hasn't come about to date, but I'm not sure what value is obtained > >> from your rename change unless we decide to completely give up on shar= ed > >> CC and if we do that, this change doesn't go far enough and we can > >> further simplify the framework to make it entirely TCP specific e.g. we > >> should probably do away with struct cc_var. > >>=20 > >> I'd argue in favour of reverting the rename and if you're gung ho about > >> making the framework TCP specific, we can start a public discussion > >> about what that should look like. > >>=20 > >=20 > > I actually was wondering about this as well. I think it ought to be re= verted to agnostic. >=20 > I probably share that view but I also agree that cc.h is not a good name. >=20 > So before we entirely revert this, can when maybe come up with a name tha= t is better than cc.h or tcp_cc.h and only make this one more change forwar= d rather than going back to the previous status quo? We use "cc" everywhere in the stack to refer to congestion control. Whether thats mod_cc or cc_<algo> or sys/netinet/cc directory. I don't see a problem with the name. Neither do I feel a need for any change. Cheers, Hiren --vvRocJ6whMXXNc9q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJWomxOXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lmo0H/3QhpQy7tHZaIE8RRoy53X7Y rFPYxtzEsJ9UOD+0ZlS0BQIqwnFXsz0USBT0uFHkNjZ91k0r715DJlicXHzP6bz0 yuLwA6yHZ1jpDvqzB3dtKLVEtIDc6MXHCMbPkqgpedlc7FwUpSOec8Rm0fTrjen0 QardN9TKQ2BdGblLDKsM1AKR6K2syAptgOy3Z0BD16ID8haAdrOs7LXs+dtD0qOP mqDi6GJ6mZz/N+wSj3Jrb5EE2Xn+ql03EJbPzRPEb2VfJuNeGkVYD+0YejhawQMw ervvTbo67vRe/viBgMWd4gj7phCZ1xRr1tDAKCW9IIty13VNHBdvhQwPC5MPMFE= =nVlK -----END PGP SIGNATURE----- --vvRocJ6whMXXNc9q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160122175217.GR33895>