From owner-svn-src-head@FreeBSD.ORG  Fri Mar  7 03:07:20 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 4896A3FE;
 Fri,  7 Mar 2014 03:07:20 +0000 (UTC)
Received: from mail108.syd.optusnet.com.au (mail108.syd.optusnet.com.au
 [211.29.132.59]) by mx1.freebsd.org (Postfix) with ESMTP id E94A9FF5;
 Fri,  7 Mar 2014 03:07:19 +0000 (UTC)
Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au
 (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133])
 by mail108.syd.optusnet.com.au (Postfix) with ESMTPS id B8C8B1A312D;
 Fri,  7 Mar 2014 14:07:17 +1100 (EST)
Date: Fri, 7 Mar 2014 14:07:15 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Alexey Dokuchaev <danfe@freebsd.org>
Subject: Re: svn commit: r262882 - head/tools/tools/net80211/wlanstats
In-Reply-To: <20140307020210.GA38155@FreeBSD.org>
Message-ID: <20140307132653.O3656@besplex.bde.org>
References: <201403070123.s271Nn1b019719@svn.freebsd.org>
 <20140307020210.GA38155@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=ddC5gxne c=1 sm=1 tr=0
 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=P3guzJ-EPTYA:10
 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=6I5d2MoRAAAA:8
 a=1v9j2Wz2wCQUb9ePlhAA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2014 03:07:20 -0000

On Fri, 7 Mar 2014, Alexey Dokuchaev wrote:

> On Fri, Mar 07, 2014 at 01:23:49AM +0000, Eitan Adler wrote:
>> New Revision: 262882
>> URL: http://svnweb.freebsd.org/changeset/base/262882
>>
>> Log:
>>   wlanstats: add help
>>
>>   - add a help (-h) flag
>>   - move usage into itsown function
>
> it looks like the only change now is that usage info always go to stdout,
> and exit code differs.  i don't think it should be mfced.

It also removes the double printing of the program name (correct) and the
printing of "usage: ", and has mounds of style bugs.

gnu utilities have a --help flag that causes similar behaviour (printing
to stdout and exiting with status 0), but they still print error messages
about usage to stderr.

Bruce