From owner-svn-src-all@freebsd.org Thu Nov 21 19:41:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D98ED1C8FDC; Thu, 21 Nov 2019 19:41:30 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47JqgZ5Wgdz3Lfp; Thu, 21 Nov 2019 19:41:30 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXsK1-0005uF-RD; Thu, 21 Nov 2019 20:41:28 +0100 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Dimitry Andric" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r354803 - in stable: 11/contrib/llvm/lib/Transforms/InstCombine 12/contrib/llvm/lib/Transforms/InstCombine References: <201911180704.xAI74xAM039993@repo.freebsd.org> Date: Thu, 21 Nov 2019 20:41:00 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: -- X-Spam-Score: -2.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED, BAYES_00 autolearn=disabled version=3.4.2 X-Scan-Signature: 9b84bad32751a42de3aa9e7877f1ca86 X-Rspamd-Queue-Id: 47JqgZ5Wgdz3Lfp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-0.99)[-0.986,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 19:41:30 -0000 On Thu, 21 Nov 2019 20:07:46 +0100, Dimitry Andric wrote: > On 21 Nov 2019, at 16:06, Ronald Klop wrote: >> >> On Mon, 18 Nov 2019 08:04:59 +0100, Dimitry Andric >> wrote: >>> Author: dim >>> Date: Mon Nov 18 07:04:59 2019 >>> New Revision: 354803 >>> URL: https://svnweb.freebsd.org/changeset/base/354803 >>> >>> Log: >>> MFC r354724: >>> Merge commit 5bbb604bb from llvm git (by Craig Topper): >>> [InstCombine] Disable some portions of foldGEPICmp for GEPs that >>> return a vector of pointers. Fix other portions. >>> llvm-svn: 370114 >>> This should fix instances of 'Assertion failed: (isa(Val) && >>> "cast() argument of incompatible type!"), function cast, file >>> /usr/src/contrib/llvm/include/llvm/Support/Casting.h, line 255', when >>> building openjdk8 for aarch64 and armv7. >>> Reported by: jbeich >>> PR: 236566 >>> >> >> >> Are there plans for an errata notice for releng-12.1 with this fix? >> That would keep Openjdk8 as a pkg on aarch64 after 12.0 goes EOL and >> pkgs will be build on 12.1. > > There should be no need for this, as release versions (and stable > branches) have their copies of clang compiled with assertions disabled. > > Hence, the assertion reported in PR 236566 cannot occur, unless you have > explicitly turned them on again and recompiled the toolchain components. > > I have tried compiling the original test case from the PR on both > 12.0-RELEASE and 12.1-RELEASE. > > On 12.0-RELEASE, which has clang version 6.0.1 (tags/RELEASE_601/final > 335540), it complains that the -fno-delete-null-pointer-checks and > -faddrsig options are unknown, but this is to be expected. The former > was important to get the original assertion. If I remove both those > options, the test case compiles just fine. > > On 12.1-RELEASE, which has clang version 8.0.1 (tags/RELEASE_801/final > 366581), the test case compiles just fine, out of the box. > > -Dimitry > Dimitry, Thank you for testing and your quick answer. Regards, Ronald.