From owner-svn-ports-head@freebsd.org Wed Jul 1 16:11:25 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F3B935660C; Wed, 1 Jul 2020 16:11:25 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49xmSF0GT0z4hND; Wed, 1 Jul 2020 16:11:24 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f195.google.com with SMTP id k18so12214604ybm.13; Wed, 01 Jul 2020 09:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1re5/MTEIX+tDItzeyF1OQPUdTDD4xZM6x6H1PZybCg=; b=YAKwmtCmNgbV5NphvvWSihj21xxzz5GIfDpLL0Kn8SBIPZE3KMXgqXaVpQleedJobr iv4W/Zum5XFXDaEaQtPPH1pYvaLVJY2H0t2O6hDiYaT4Iy6PGJfIXBG8f0qY/OK3hbFE Ray5ThQ/thGSjvarVImfNAftXrUdpbhTOJovlJj5ivCzu8/xpCIq0uSVavrfb6s8JsC6 aBzccXJY6hJOUFjfXHWHr/Ws8Ojp6VxRySq58/7fmS+oBErILa5J91INyhRI2NxtAFXv 78R9bAaPSTEdVwz/4/GDE1yigx1hFK9iRBzHGbvEu9wl53N76mwjDQFXCDyBvWDyGyk0 t3Mg== X-Gm-Message-State: AOAM531Efn8mN3ir4qjdblh0GC4JDHm7miPjjkKhiu3ZbOAkXU73C84o uJlNMJ7kq/0Gf7+T2iCCG86nmzpGpIJ6eyFQzRXEafRchbE= X-Google-Smtp-Source: ABdhPJzLRqJ83ZNnPmVmeVNxqfM8jjWMh8exMy8YBF5bOdoJJiuRhHvIQeQWmD5x3ZynwgELUe+V4TW+LT+Ympxpq8o= X-Received: by 2002:a25:c646:: with SMTP id k67mr44912461ybf.110.1593619883139; Wed, 01 Jul 2020 09:11:23 -0700 (PDT) MIME-Version: 1.0 References: <202007011406.061E6Cxt041119@repo.freebsd.org> <20200701151607.GA6554@FreeBSD.org> <20200701155947.GA50158@FreeBSD.org> In-Reply-To: <20200701155947.GA50158@FreeBSD.org> From: Li-Wen Hsu Date: Thu, 2 Jul 2020 00:11:11 +0800 Message-ID: Subject: Re: svn commit: r540967 - in head/net/lualdap: . files To: Alexey Dokuchaev Cc: Jason Bacon , ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49xmSF0GT0z4hND X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 16:11:25 -0000 On Wed, Jul 1, 2020 at 11:59 PM Alexey Dokuchaev wrote: > > On Wed, Jul 01, 2020 at 10:28:15AM -0500, Jason Bacon wrote: > > On 2020-07-01 10:16, Alexey Dokuchaev wrote: > > > On Wed, Jul 01, 2020 at 02:06:12PM +0000, Li-Wen Hsu wrote: > > >> New Revision: 540967 > > >> URL: https://svnweb.freebsd.org/changeset/ports/540967 > > >> > > >> Log: > > >> Update to 1.2.5 > > >> > > >> ... > > >> -MAKE_ARGS+= LUA_LIBDIR="${LUA_LIBDIR}" \ > > >> - LUA_INC="${LUA_INCDIR}" \ > > >> - OPENLDAP_LIB="-L${LOCALBASE}/lib -lldap" \ > > >> - LUA_VERSION_NUM="${LUA_VER_STR}0" \ > > >> - CC="${CC}" > > >> +MAKE_ARGS+= CPPFLAGS="-I${LOCALBASE}/include -I${LUA_INCDIR}" \ > > >> + LDFLAGS="-L${LOCALBASE}/lib" \ > > >> + CC=${CC} > > > Dropping quotes around ${CC} can potentially break things and also > > > had contributed some unnecessary repo churn. :( > > > > I would have thought ${CC} is always just the compiler name sans > > flags/whitespace, but danfe is correct. There's one case in Mk that > > would call for quotes: > > Another thing which rings the bell is ccache which can be invoked as > "ccache compiler [compiler options]", thus CC="ccache compiler". Nice catch! Thanks and fixed in r540974. Li-Wen