From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jan 16 03:10:01 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFCEB106566B for ; Fri, 16 Jan 2009 03:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9DF528FC0C for ; Fri, 16 Jan 2009 03:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n0G3A1i7026610 for ; Fri, 16 Jan 2009 03:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n0G3A1XG026609; Fri, 16 Jan 2009 03:10:01 GMT (envelope-from gnats) Resent-Date: Fri, 16 Jan 2009 03:10:01 GMT Resent-Message-Id: <200901160310.n0G3A1XG026609@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Craig Leres Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 420D0106564A for ; Fri, 16 Jan 2009 03:05:11 +0000 (UTC) (envelope-from leres@ee.lbl.gov) Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [131.243.2.202]) by mx1.freebsd.org (Postfix) with ESMTP id 2C6838FC13 for ; Fri, 16 Jan 2009 03:05:10 +0000 (UTC) (envelope-from leres@ee.lbl.gov) Received: from hot.ee.lbl.gov (hot.ee.lbl.gov [131.243.2.203]) (authenticated bits=0) by fun.ee.lbl.gov (8.14.3/8.14.3) with ESMTP id n0G2huBe044845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Thu, 15 Jan 2009 18:43:56 -0800 (PST) Message-Id: <496FF46C.3080703@ee.lbl.gov> Date: Thu, 15 Jan 2009 18:43:56 -0800 From: Craig Leres To: freebsd-gnats-submit@FreeBSD.org Cc: Subject: ports/130598: [PATCH] mail/dovecot: rc.d errors when not enabled and without dovecot.conf X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2009 03:10:02 -0000 >Number: 130598 >Category: ports >Synopsis: [PATCH] mail/dovecot: rc.d errors when not enabled and >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 16 03:10:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Craig Leres >Release: FreeBSD 7.1-RELEASE i386 >Organization: Lawrence Berkeley National Laboratory >Environment: FreeBSD hot.ee.lbl.gov 7.1-RELEASE FreeBSD 7.1-RELEASE #2: Sun Jan 11 12:03:47 PST 2009 leres@hot.ee.lbl.gov:/usr/src/7.1-RELEASE/sys/i386/compile/LBLSMP i386 >Description: If the dovecot port is installed but not enabled in /etc/rc.conf and there is no /usr/local/etc/dovecot.conf configuration file, the rc.d script outputs some errors no startup. >How-To-Repeat: # grep dovecot /etc/rc.conf # ls /usr/local/etc/dovecot.conf ls: /usr/local/etc/dovecot.conf: No such file or directory # pkg_info | grep dovecot dovecot-1.1.7_1 Secure and compact IMAP and POP3 servers # /usr/local/etc/rc.d/dovecot start Error: Can't open configuration file /usr/local/etc/dovecot.conf: No such file or directory Fatal: Invalid configuration in /usr/local/etc/dovecot.conf Error: Can't open configuration file /usr/local/etc/dovecot.conf: No such file or directory Fatal: Invalid configuration in /usr/local/etc/dovecot.conf >Fix: The attached patch checks the enable variable before running the "multiple instances" startup block. --------------090804000004000903020405 Content-Type: text/plain; name="patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.txt" --- dovecot.sh.in.virgin 2009-01-15 18:14:05.000000000 -0800 +++ dovecot.sh.in 2009-01-15 18:30:15.000000000 -0800 @@ -47,6 +47,10 @@ run_rc_command start } +if ! checkyesno ${name}_enable; then + exit 0 +fi + # To start multiple instances of dovecot set dovecot_config to # a space seperated list of configuration files. for config in ${dovecot_config}; do --------------090804000004000903020405-- >Release-Note: >Audit-Trail: >Unformatted: This is a multi-part message in MIME format. --------------090804000004000903020405 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit without dovecot.conf