Date: Tue, 14 Feb 2023 10:48:01 +0100 From: Emanuel Haupt <ehaupt@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Emanuel Haupt <ehaupt@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ce282f9818c3 - main - mail/nbsmtp: Does not build with clang 15 Message-ID: <20230214104801.0f50cc64788e1bc2753f3fb2@FreeBSD.org> In-Reply-To: <Y%2BtX8TI1iUzwMbr4@FreeBSD.org> References: <202302131420.31DEKZMF076523@gitrepo.freebsd.org> <Y%2Br5FshqbwVIfL0o@FreeBSD.org> <20230214101626.a419aa8e076809d267c40a1b@FreeBSD.org> <Y%2BtX8TI1iUzwMbr4@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Tue, Feb 14, 2023 at 10:16:26AM +0100, Emanuel Haupt wrote:
> > Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > > On Mon, Feb 13, 2023 at 02:20:35PM +0000, Emanuel Haupt wrote:
> > > > commit ce282f9818c344616ad9e3df29d01dab55acf8b2
> > > >
> > > > mail/nbsmtp: Does not build with clang 15
> > > >
> > > > +.include <bsd.port.pre.mk>
> > > > +
> > > > +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1400079
> > > > +USE_GCC= yes
> > > > +.endif
> > >
> > > Why not just fix the code instead of pulling whole another
> > > compiler suite? Looks like it bogusly assigns (char)NULL instead
> > > of '\0' in several places (unless, of course, there are other,
> > > more complicated errors, but commit log does not mention anything
> > > specific).
> >
> > I'll have a list of ports that fail. My main priority is to unbreak
> > the ports on main and have working packages again. Fixing the the
> > code to build with clang 15 is a midterm priority.
>
> Clang 15 simply revealed the problem with the code, easily fixable.
> By falling back to GCC you'd rage your users and merely postpone the
> solution until GCC would become more strict and start complaining
> just as Clang did just now. Fixing this particular bug would take
> less time than calculating the 1400079 values for OSVERSION above. :-)
Cool, I'll await yout patch :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230214104801.0f50cc64788e1bc2753f3fb2>