Date: Wed, 24 Apr 2013 16:43:51 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Chris Rees <crees@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, svn-ports-all@freebsd.org, Jimmy Olgeni <olgeni@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r316469 - head/databases/slony1v2 Message-ID: <51784407.2090801@FreeBSD.org> In-Reply-To: <CADLo83_wFKh5AA_ecttfy9oYy8cYEPTWEOGDTAv_E_ASLLU%2BZw@mail.gmail.com> References: <201304241850.r3OIovPc079999@svn.freebsd.org> <51782B87.2090000@FreeBSD.org> <alpine.BSF.2.00.1304242105250.29749@olgeni.olgeni> <517830D2.5060600@FreeBSD.org> <CADLo83_VLFq4kZ683u9e63T-mfF5am1-MGbFR3K4kV6L5TviQQ@mail.gmail.com> <51783462.4090904@FreeBSD.org> <CADLo83_wFKh5AA_ecttfy9oYy8cYEPTWEOGDTAv_E_ASLLU%2BZw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 2013-04-24 16:26:14 -0400, Chris Rees wrote: > On 24 April 2013 20:37, Jung-uk Kim <jkim@freebsd.org> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >> >> On 2013-04-24 15:30:57 -0400, Chris Rees wrote: >>> On 24 April 2013 20:21, Jung-uk Kim <jkim@freebsd.org> wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >>>> >>>> On 2013-04-24 15:08:00 -0400, Jimmy Olgeni wrote: >>>>> >>>>> On Wed, 24 Apr 2013, Jung-uk Kim wrote: >>>>> >>>>>> On 2013-04-24 14:50:57 -0400, Jimmy Olgeni wrote: >>>>>>> Author: olgeni Date: Wed Apr 24 18:50:57 2013 New >>>>>>> Revision: 316469 URL: >>>>>>> http://svnweb.freebsd.org/changeset/ports/316469 >>>>>>> >>>>>>> Log: - Use bsd.port.options.mk. - PORTDOCS should not >>>>>>> be conditional. - Whitespace fix. >>>>>> ... >>>>>> >>>>>> bsd.port.mk says "(PORTDOCS) should not be set when no >>>>>> documentation files are installed" and I believe it is >>>>>> actually correct. >>>>> >>>>> I found this on the Porter's Handbook: >>>>> >>>>> If a directory is listed in PORTDOCS or matched by a glob >>>>> pattern from this variable, the entire subtree of >>>>> contained files and directories will be registered in the >>>>> final packing list. If the DOCS option has been unset then >>>>> files and directories listed in PORTDOCS would not be >>>>> installed or added to port packing list. >>>>> >>>>> It seems to behave correctly, at least in the PORTDOCS=* >>>>> case. >>>> >>>> It may work for now because bsd.options.mk has backward >>>> compat shim, i.e., >>>> >>>> ## Now some compatibility .if empty(PORT_OPTIONS:MDOCS) >>>> NOPORTDOCS= yes .endif >>>> >>>> It won't work when we deprecate the compat shims. >>> >>> Yes, bsd.port.mk needs fixing there. >> >> Agreed. >> >> We should refrain from blindly making PORTDOCS unconditional >> until we resolve the issue, IMHO. > > Huh? > > It's not an issue at all, it's just that bsd.port.mk relies on a > compat shim. > > Removing the compat shim would cause an issue, but we're not there > yet, and it's a trivial fix. Including PORTDOCS conditionally has > always been wrong. My point is it may be wrong with NOPORTDOCS but it is okay with optionsNG until we fix the issue. Therefore, sweeping changes are not necessary. Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBAgAGBQJReEQHAAoJECXpabHZMqHOq18H/A/zQ9d895KkgAUq/3QqD1og 4V0EBOK+5oP5fXcbQFCfk46dNveWGcFhiGZRCQZMx9ZQhSylx1nsJBjKNP3sH1M/ o/1LSMXcQmcRm070lVjYd7eHSV98P3OO5gVdjRQG267t5nfK7NXfCqHwz06mA0hQ UBWICFcQULtuvOjUU6uH+nXAEunVDk7z5Cab8nUxuzyvyiRKFgldsjrXn/logQS3 3nbtRBc5eq3WPisDrOK460PBI7Zprga3X0u3+MAzr8T0GFRqJrNdMSKmvvfvzoTr 3+zEMC+4hZbhrfEf/DnnfCPSCi+vZs1VFFcEHqqMj0jNRtBk4PpgNmIYInfuz24= =fSlO -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51784407.2090801>