From owner-svn-src-all@FreeBSD.ORG Fri Dec 20 17:05:43 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CA8EE48D; Fri, 20 Dec 2013 17:05:43 +0000 (UTC) Received: from mail-qc0-x234.google.com (mail-qc0-x234.google.com [IPv6:2607:f8b0:400d:c01::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 53F981611; Fri, 20 Dec 2013 17:05:43 +0000 (UTC) Received: by mail-qc0-f180.google.com with SMTP id w7so2456949qcr.11 for ; Fri, 20 Dec 2013 09:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d6I2ymUaVjTk7b5OW/LMzZA5wZJ5gxKwqkSy3ak2Nzk=; b=e+fuxmklGHS1aQ4f4vxO6gLk4dC/O3zqrVIrnM9py1t337KKmt1Te5YI1sgqd97XzW kCorzBFGKav0a6mx+4QKAJTGr78cS7QPq4tYRe7z7UZPReYKS/3vAjXgH2joOsGskCEW N4XD6s70N88Vckqmn2sjlip14V2W8zFxGtVzxAxCPh7YddfFHk/k4scGX760/AQvxx3P GabPxUAzvoB3ZFvUtzMhgSROfGN5m7XgjN0cn88qCdQMNgeRD1Cfan0bUuH8sD9SfJlV t/TP+0Kc8+VvDj6txEsm1/lJOVGPEuSMg87ddKbx2a+1nlj1B7Ha+e55SoY7/QwSvN9W irkg== MIME-Version: 1.0 X-Received: by 10.49.76.66 with SMTP id i2mr15764513qew.35.1387559142458; Fri, 20 Dec 2013 09:05:42 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.224.53.200 with HTTP; Fri, 20 Dec 2013 09:05:42 -0800 (PST) In-Reply-To: <20131220084419.GK71033@FreeBSD.org> References: <201312200741.rBK7f3tL038123@svn.freebsd.org> <20131220084419.GK71033@FreeBSD.org> Date: Fri, 20 Dec 2013 09:05:42 -0800 X-Google-Sender-Auth: dBjenF2o2H2n3TgCCyZgyxScIRQ Message-ID: Subject: Re: svn commit: r259642 - head/sys/netinet From: Adrian Chadd To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Dec 2013 17:05:43 -0000 On 20 December 2013 00:44, Gleb Smirnoff wrote: > I didn't get to review of actual patch, but IMO it would be better > just to remove the code, not ifdef 0 it. The code ifdefed has zero > probability to be enabled in its current form. If we ever fix it, code > would look very different. > > No reason to do followup commit, that was just me muttering. I figured it would be nicer in the short term to #if 0 it out whilst some other discussions went on, just to make it really obvious in the short term where the check was done. It's quite possible I'll eventually just trim it entirely out. Thanks, -a