Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Oct 2020 13:50:47 +0200
From:      Mathieu Arnold <mat@freebsd.org>
To:        Renato Botelho <garga@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r552232 - head/devel/git
Message-ID:  <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc>
In-Reply-To: <202010131132.09DBWRIZ099906@repo.freebsd.org>
References:  <202010131132.09DBWRIZ099906@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--or6wmyjvudyaqoxf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Oct 13, 2020 at 11:32:27AM +0000, Renato Botelho wrote:
> Author: garga
> Date: Tue Oct 13 11:32:26 2020
> New Revision: 552232
> URL: https://svnweb.freebsd.org/changeset/ports/552232
>=20
> Log:
>   Simplify logic to define COMMENT
>  =20
>   Submitted by:	bapt
>=20
> Modified:
>   head/devel/git/Makefile
>=20
> Modified: head/devel/git/Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/devel/git/Makefile	Tue Oct 13 11:30:50 2020	(r552231)
> +++ head/devel/git/Makefile	Tue Oct 13 11:32:26 2020	(r552232)
> @@ -12,12 +12,11 @@ EXTRACT_ONLY=3D	${DISTNAME}${EXTRACT_SUFX} \
>  		${PORTNAME}-manpages-${DISTVERSION}${EXTRACT_SUFX}
> =20
>  MAINTAINER=3D	garga@FreeBSD.org
> -.if ${FLAVOR:Udefault} =3D=3D default
>  COMMENT=3D	Distributed source code management tool
> -.elif ${FLAVOR:U} =3D=3D gui
> -COMMENT=3D	Distributed source code management tool (GUI enabled flavor)
> +.if ${FLAVOR:U} =3D=3D gui
> +COMMENT+=3D	(GUI enabled flavor)
>  .elif ${FLAVOR:U} =3D=3D lite
> -COMMENT=3D	Distributed source code management tool (lite flavor)
> +COMMENT+=3D	(lite flavor)
>  .endif

If one really wanted to make it clear and simple, one could even write:

COMMENT=3D	Distributed source code management tool ${COMMENT_${FLAVOR}}
COMMENT_gui=3D	(GUI enabled flavor)
COMMENT_lite=3D	(lite flavor)

--=20
Mathieu Arnold

--or6wmyjvudyaqoxf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAl+G5hNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgLlig//T2vr1bFNOQrA1DKokLq0+z2fGwP9QhMXuu4SeCnFkSJZLeeIIFHPjGcc
Dv9TMbtPii9jnDY0tUGcEbLbFGAQYVHs0AIGl28hekUkeZUrCNGzfw08A2GXlRzY
GB9BYnXz0zEBnKOQU/tgDKDA6mc+P5+UVIXMOPuTqrRfM7UoMJ60oEG5PpfrV10y
4jd6iqtB724c8/CEMV/VCvgjn+jh1lfiBd21SVonWQtBohySKd8myzhhsY9hGWiQ
uO9T+1Z07bGVPKZ+s18PiqCcn3Kukev6+9CDn/N5vQhT2OcFUm+RgXblFeLhsL49
91G8bL/SnF00ouZJW1OvdTR4KnSYft0wlKII9lV5njj1MLtPBHQkEk/GpdodZNnd
GjxUk8yqiMUEtSFnVPa9bttGLYT5arb3VAWIyNQ5H+/OSjVC2LEQLlx6KkCBsvJ6
DN3AKezOxlVK6ssJ8X3ha0Nc4A2ogZsaqX9THbfU6qrVzhrAfmh/G90hBI5vRzE5
95fhLOd3IOL+ZVaCUADVU4QB4BtFPlJuboS0qrGEF4a5qrznvqra+HmCFRIA7hsY
aPKab9uPqoFbV5G2+1STnxxlVqgaUXta0SI3x7tARtTDi+WDETBT4sej8LJx+hZA
5e+dM6QV6PK3cleAjlMLtGk7O2jwNc9OSxkn5rotskgaC8y03GE=
=RSPJ
-----END PGP SIGNATURE-----

--or6wmyjvudyaqoxf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201014115047.omi53rjydfvoabyk>