From owner-freebsd-hackers@freebsd.org Wed Feb 17 18:15:39 2021 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B8E954EC79 for ; Wed, 17 Feb 2021 18:15:39 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DgmGv27WHz4dDl; Wed, 17 Feb 2021 18:15:35 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 1639D2CFDC; Wed, 17 Feb 2021 18:15:32 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 6CF5049F71; Wed, 17 Feb 2021 19:15:30 +0100 (CET) From: "Kristof Provost" To: "Daniel Ebdrup Jensen" Cc: freebsd-hackers@freebsd.org Subject: Re: MFCing a src commit if I forgot the MFC tags Date: Wed, 17 Feb 2021 19:15:29 +0100 X-Mailer: MailMate (1.13.2r5673) Message-ID: In-Reply-To: <20210217180400.vcyhf6as4eevnslp@nerd-thinkpad.local> References: <7b466cd67933ddef2d4eb9b6bdd466e1@freebsd.org> <503F17CD-B7CD-4F37-9422-13D6A79C552C@FreeBSD.org> <20210217180400.vcyhf6as4eevnslp@nerd-thinkpad.local> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Technical discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 18:15:39 -0000 On 17 Feb 2021, at 19:04, Daniel Ebdrup Jensen wrote: > On Wed, Feb 17, 2021 at 06:58:42PM +0100, Kristof Provost wrote: >> On 17 Feb 2021, at 18:46, Neel Chauhan wrote: >>> I have this commit: = >>> https://cgit.freebsd.org/src/commit/?id=3Da08cdb6cfb1c84b80b5337d46c5= 74b55d0e15c63 >>> >>> This commit enables IPFW NAT to NAT a certain port range on the = >>> outside, much like a Carrier Grade NAT setup. >>> >>> When I committed this, I forgot to add the MFC tags. However, I = >>> would like to MFC this commit. >>> >>> Can I just commit this on my own to stable/12 and stable/1, or is = >>> there something special I need to do? >>> >> MFC tags are indicative, not mandatory. I sometimes end up not MFCing = >> things I=E2=80=99d tagged with an =E2=80=98MFC after=E2=80=99 after al= l. >> It=E2=80=99s perfectly okay to MFC things that don=E2=80=99t have a ta= g. = >> (Although if it=E2=80=99s not your commit it may be a good idea to ask= the = >> author why it wasn=E2=80=99t tagged.) >> >> This commit has been in main long enough to be an MFC candidate, so = >> you can merge it to stable/13 and stable/12 at any time. >> > I always just thought MFC field was a way of ensuring that you get a > notification about it on email? > That=E2=80=99s one effect of it, yes. It also communicates your intention= to = merge this (which is why you get the reminder). It=E2=80=99s not mandatory to follow through on it and lack of the tag do= es = not stop you from merging it after all (but does mean you won=E2=80=99t g= et a = reminder). Best regards, Kristof