From nobody Fri Feb 27 10:05:53 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fMkVZ4sXxz6Sbv8 for ; Fri, 27 Feb 2026 10:05:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fMkVZ3tR3z4Cbh for ; Fri, 27 Feb 2026 10:05:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772186758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nSXKT1O6tJ5r10WmV4o5FEHn8NM9mzThjMupWg6T59I=; b=OhJDc3NIwrUCz2QXOcf6c49fXjetgGeuWpqwfkD6YK5wShW2x4lzeDqKPHMwq5A2xtQ4af 6rL+VYMYh6/HvH9jJ31LW+vl9XGV0iFuj3GxQi9Jap6lEYN45jKPunc3xOOSSmM8aor26d iaxpW8zZ+JMHLQfDviYe5KmZBUT8Jgs8wXMjHiwfaHKiLUvgEi+d2zP/rA5+OHcUEtauIa 83re/3WutdYvkXM1TND4jjfPRjP197aHbGSYrKf20zbVin4WaUuQGvwC0mjbsVoRneMX9e Fc6T88pktoFW90h3CkExF+PIHNevgmdTeTjILJdsx5YILjqI/Ett8hzTWz1wNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1772186758; a=rsa-sha256; cv=none; b=iTxuvBp42j/fmcj75VSt2g/1Q1cN0hY739dJejzK2xTecxXlp+M13JD41sHtPc/1Rw5Ymw fRh1cWF+nDCctwu6t1Z+K1M5Xy/rKwN4tVeYb416fLsFj7GXXe33qWxGH8W/sBCxT/4eis XHWrlqWNEqE72waoJYaWmORLgNLKmItZPhRBntj00aKEutAqiwHoeQogKUqkOsq3s0gvHc ORIgXokZfkE7IytBOPXMRylg0e/64Zzt2UGflNSPVVvEq6fYonRKyG8tT36h1HSUWwtGgs v5l2DdP/U/wOnPI/k+9CBAShxyBPxJKkXd3kgCgDaPZ99MolT4a3dgKbif44yw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1772186758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nSXKT1O6tJ5r10WmV4o5FEHn8NM9mzThjMupWg6T59I=; b=OALxxdUbbGW8S8UgD2+2ExRQC2wD2gaG8mfeNY4IHwIJTdFnauxqqGhz14loeyyQxFKu8B Kc+JGVi/06ONoeEju5iTizsmCOjUTfexE1Q+m0SFsG0jrwhxJt7/V8hINxh+H6znTdylu+ I0F+tjTUTPqrhkCDBQViR/9GTgBt2jEpP7s7kNW17jd7yS8Q2TgIj7iw+nq0NrZp452SEA q3wHeA+ac2Pf3WslfWbotDqPVFvI/BFJU8+WGChqd3zmcjAMacwG3STD3m8GwB+jfLKwi7 egSLNfz7yJJ3PHG/3oq9RkhNloSBai7datDvneMZQGFfyDQxJmghKii71DzVyA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fMkVZ3LQ2z1BQs for ; Fri, 27 Feb 2026 10:05:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30858 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 27 Feb 2026 10:05:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: d851e0070499 - stable/15 - ngctl: Fix getline loop List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: d851e0070499b8b34f3cf1efb956aefa6faf6859 Auto-Submitted: auto-generated Date: Fri, 27 Feb 2026 10:05:53 +0000 Message-Id: <69a16c81.30858.65dde7ed@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=d851e0070499b8b34f3cf1efb956aefa6faf6859 commit d851e0070499b8b34f3cf1efb956aefa6faf6859 Author: Dag-Erling Smørgrav AuthorDate: 2026-02-24 14:23:39 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-02-27 10:05:26 +0000 ngctl: Fix getline loop I misremembered when I wrote this code: getline() returns -1 on EOF, not zero, so the loop condition and the error check are both incorrect (though in practice getline() will never return 0). MFC after: 3 days Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat") Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D55487 (cherry picked from commit 6c4777c59325c2cfefcce0c466b3bf475404a550) --- usr.sbin/ngctl/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/ngctl/main.c b/usr.sbin/ngctl/main.c index b58de1e042b3..2b711fd4155a 100644 --- a/usr.sbin/ngctl/main.c +++ b/usr.sbin/ngctl/main.c @@ -243,7 +243,7 @@ ReadFile(FILE *fp) unsigned int lineno = 0; int rtn = CMDRTN_OK; - while ((len = getline(&line, &sz, fp)) > 0) { + while ((len = getline(&line, &sz, fp)) >= 0) { lineno++; if (*line == '#') continue; @@ -252,7 +252,7 @@ ReadFile(FILE *fp) break; } } - if (len < 0) + if (ferror(fp)) rtn = CMDRTN_ERROR; free(line); return (rtn);