From owner-freebsd-current@FreeBSD.ORG Thu Mar 4 20:53:06 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C6ACD16A4CE; Thu, 4 Mar 2004 20:53:06 -0800 (PST) Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id AFE9F43D3F; Thu, 4 Mar 2004 20:53:06 -0800 (PST) (envelope-from alc@cs.rice.edu) Received: from localhost (calypso.cs.rice.edu [128.42.1.127]) by cs.rice.edu (Postfix) with ESMTP id 41BE64ADED; Thu, 4 Mar 2004 22:53:06 -0600 (CST) Received: from cs.rice.edu ([128.42.1.30]) by localhost (calypso.cs.rice.edu [128.42.1.127]) (amavisd-new, port 10024) with LMTP id 15240-01; Thu, 4 Mar 2004 22:53:05 -0600 (CST) Received: by cs.rice.edu (Postfix, from userid 19572) id D5F2D4ADE0; Thu, 4 Mar 2004 22:53:05 -0600 (CST) Date: Thu, 4 Mar 2004 22:53:05 -0600 From: Alan Cox To: Robert Watson Message-ID: <20040305045305.GA21071@cs.rice.edu> References: <4047F3F8.1080207@imimic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-Virus-Scanned: by amavis-20030616-p7 at cs.rice.edu cc: alc@freebsd.org cc: "Alan L. Cox" cc: Nate Lawson cc: current@freebsd.org cc: Marcel Moolenaar Subject: Re: bug in vm_contig.c? [was: Re: ACPI crash with recent changes] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2004 04:53:06 -0000 On Thu, Mar 04, 2004 at 11:28:04PM -0500, Robert Watson wrote: > > On Thu, 4 Mar 2004, Alan L. Cox wrote: > > > Please test the attached patch instead. In order to avoid a race > > condition, it is necessary for the loop to begin with "start" rather > > than "start + 1". What is both unnecessary and wrong is the physical > > contiguity check. (My bad. :-() In other words, the test that the page > > is still free must be repeated because of the dropping of the free page > > queue lock, but contiguity once true is always true. > > Using this patch, my testbox boots just fine. > Thanks. I've committed the patch. Alan