From owner-svn-src-projects@FreeBSD.ORG Wed Oct 5 05:10:48 2011 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D819C1065890; Wed, 5 Oct 2011 05:10:48 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward15.mail.yandex.net (forward15.mail.yandex.net [IPv6:2a02:6b8:0:801::5]) by mx1.freebsd.org (Postfix) with ESMTP id 5356C8FC12; Wed, 5 Oct 2011 05:10:48 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward15.mail.yandex.net (Yandex) with ESMTP id 9A6409E3A24; Wed, 5 Oct 2011 09:10:46 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1317791446; bh=LKKq3G16Qdksod2wmwDzNfOBkbIgM691irgyZtn4x0Q=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=tKWSePKyr2jPg9AAZUp527oA2IkAhpDefEd8XUMzTVQBWzBSRPCWpcwSg+bQhpn/y ul61nF1CUDNEbl2fgj+hFOx60JCur2NlScZPY5fLAkIqvUrwgX7KknIG6FqBnTalg0 aau7+GytTF71J2mKTldvX0Y6VcIEkyZQ/vHQNrdE= Received: from smtp14.mail.yandex.net (localhost [127.0.0.1]) by smtp14.mail.yandex.net (Yandex) with ESMTP id 710B41B602EE; Wed, 5 Oct 2011 09:10:46 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1317791446; bh=LKKq3G16Qdksod2wmwDzNfOBkbIgM691irgyZtn4x0Q=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=tKWSePKyr2jPg9AAZUp527oA2IkAhpDefEd8XUMzTVQBWzBSRPCWpcwSg+bQhpn/y ul61nF1CUDNEbl2fgj+hFOx60JCur2NlScZPY5fLAkIqvUrwgX7KknIG6FqBnTalg0 aau7+GytTF71J2mKTldvX0Y6VcIEkyZQ/vHQNrdE= Received: from ns.kirov.so-ups.ru (ns.kirov.so-ups.ru [178.74.170.1]) by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTP id AjOSAW1Z-AkOqYQj1; Wed, 5 Oct 2011 09:10:46 +0400 X-Yandex-Spam: 1 Message-ID: <4E8BE6D5.9030107@yandex.ru> Date: Wed, 05 Oct 2011 09:10:45 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: "Lev A. Serebryakov" References: <201110041708.p94H8O8f069977@svn.freebsd.org> In-Reply-To: <201110041708.p94H8O8f069977@svn.freebsd.org> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226011 - projects/geom-events/sys/geom/part X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2011 05:10:48 -0000 On 04.10.2011 21:08, Lev A. Serebryakov wrote: > Author: lev (ports committer) > Date: Tue Oct 4 17:08:24 2011 > New Revision: 226011 > URL: http://svn.freebsd.org/changeset/base/226011 > > Log: > Add g_notify_*() calls to geom_part > > Modified: > projects/geom-events/sys/geom/part/g_part.c > > Modified: projects/geom-events/sys/geom/part/g_part.c > ============================================================================== > --- projects/geom-events/sys/geom/part/g_part.c Tue Oct 4 17:07:56 2011 (r226010) > +++ projects/geom-events/sys/geom/part/g_part.c Tue Oct 4 17:08:24 2011 (r226011) > @@ -2016,6 +2016,7 @@ g_part_orphan(struct g_consumer *cp) > { > struct g_provider *pp; > struct g_part_table *table; > + struct g_part_entry *e; > > pp = cp->provider; > KASSERT(pp != NULL, ("%s", __func__)); > @@ -2026,6 +2027,11 @@ g_part_orphan(struct g_consumer *cp) > table = cp->geom->softc; > if (table != NULL && table->gpt_opened) > g_access(cp, -1, -1, -1); > + > + LIST_FOREACH(e, &table->gpt_entry, gpe_entry) { > + g_notify_destroyed(e->gpe_pp); > + } > + In some cases you can get panic here. Also geom_part can destroy its providers in several places, not only when it is orphaned. -- WBR, Andrey V. Elsukov