From owner-freebsd-ports@FreeBSD.ORG Thu Aug 26 08:48:56 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D38C1065670; Thu, 26 Aug 2010 08:48:56 +0000 (UTC) (envelope-from ehaupt@critical.ch) Received: from mx.critical.ch (mx.critical.ch [62.2.45.171]) by mx1.freebsd.org (Postfix) with ESMTP id 8704C8FC0C; Thu, 26 Aug 2010 08:48:55 +0000 (UTC) Received: from wiggles.bwns.ch (localhost [IPv6:::1]) by mx.critical.ch (8.14.3/8.14.3/critical-1.0) with SMTP id o7Q8Nutk069323; Thu, 26 Aug 2010 10:23:56 +0200 (CEST) (envelope-from ehaupt@critical.ch) Date: Thu, 26 Aug 2010 10:23:56 +0200 From: Emanuel Haupt To: Emanuel Haupt Message-Id: <20100826102356.b5e71239.ehaupt@critical.ch> In-Reply-To: <20100824211420.3ecced97.ehaupt@FreeBSD.org> References: <20100817060114.GA86738@icarus.home.lan> <20100824153157.GA63745@icarus.home.lan> <20100824211420.3ecced97.ehaupt@FreeBSD.org> X-Mailer: Sylpheed 3.0.3 (GTK+ 2.20.1; amd64-portbld-freebsd8.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alex@freebsd.org, Garrett Wollman , freebsd-ports@freebsd.org, Jeremy Chadwick , Goncharov Subject: Re: shells/bash and the libiconv dependency mess X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2010 08:48:56 -0000 Emanuel Haupt wrote: > Jeremy Chadwick wrote: > > On Mon, Aug 16, 2010 at 11:01:14PM -0700, Jeremy Chadwick wrote: > > > Let me explain what transpired in chronological order: > > > > > > On 2010/05/11, ehaupt committed the following patch: > > > > > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/shells/bash/files/patch-Makefile.in > > > > > > And bumped PORTREVISION (from 0 to 1) in the Makefile. This > > > unconditionally made bash require libiconv, and the only > > > justification is "fix statically linked version". > > > > > > Those of us who use WITHOUT_NLS or who do not have libiconv > > > already on their systems (from another port) immediately notice > > > the problem (bash will no longer build): > > > > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=147747 > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=148329 > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=149218 > > > > > > Three months goes by and finally something is committed to fix the > > > problem on 2010/08/06. Except the fix doesn't make any sense; all > > > it does is make libiconv a mandatory dependency (USE_ICONV): > > > > > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/shells/bash/Makefile#rev1.123 > > > > > > This, of course, means that WITHOUT_NLS is broken and doesn't work > > > as it's supposed to, since libiconv is now a mandatory requirement > > > (it doesn't need to be): > > > > > > # make WITHOUT_NLS=true all-depends-list > > > /usr/ports/devel/bison > > > /usr/ports/converters/libiconv > > > /usr/ports/devel/m4 > > > /usr/ports/devel/libtool22 > > > > > > Why was this done the way it was? patch-Makefile.in should be > > > removed and instead replaced with a REINPLACE_CMD that handles the > > > conditionals (WITH_STATIC_BASIC, WITHOUT_NLS, etc.) in a more > > > clean manner. > > > > > > And where are the details of the supposed "statically linked > > > version" problem? > > > > > > Sorry if I sound angry, but this whole situation is a mess, and > > > shells/bash is a very important port. If someone wants me to put > > > my money where my mouth is and go + clean it up I'll be happy to. > > > Testing all the different quirk combinations really isn't that > > > complex. > > > > Since I didn't really get any answers regarding this predicament, I > > went ahead and did the necessary effort. Below are my QA notes. > > The patch is available here: > > > > http://jdc.parodius.com/freebsd/bash-without-nls.patch > > The patch works for me. One minor thing, PORTREVISION should be > bumped. > > > Please note the required removal of files/patch-Makefile.in. > > > > I can file a PR for all this if need be, just let me know. > > Please do that, that way I can commit the patch after a 14 day > maintainer timeout. I created: http://www.freebsd.org/cgi/query-pr.cgi?pr=149981 Emanuel