From owner-freebsd-fs@FreeBSD.ORG Fri Nov 7 13:31:20 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B3279F56 for ; Fri, 7 Nov 2014 13:31:20 +0000 (UTC) Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F79C382 for ; Fri, 7 Nov 2014 13:31:19 +0000 (UTC) Received: by mail-wi0-f179.google.com with SMTP id h11so4560216wiw.12 for ; Fri, 07 Nov 2014 05:31:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=r7+7dh6eo1UubEJieWcdIzDXuM2oUvyO5FWsWRMDD+8=; b=K/B7hJmeDvwuwlJSqX8pK8Xxv2ERcIbJRKmu0PXpJ5YP5q5rk5PMyVpqDbdz25rTBr NF65s21HK3RjHe+JSStUSi9OLq2YbVoPYN7hmI6SEGnLoWimT/HO+iYFYij+UAXm8EjJ 8bh609diryJZLZlazPbv/mmH4tWUDxu48gkTxy3OlNwtOyrDWMiqtFiwBGlxVyHFmFii OfW+fB1FS5ukBFnAmSimpQ8Cg4e1TZYw5HfXv4mH7d2OsXQIemZAzubAFJ0GRiCyQTIT ByYrxCM2FC5rjZiufF97cwnTsPbUeMkNbCoQ82gnmmireoQl58QET09tt/ocugr1GObF fiIQ== X-Gm-Message-State: ALoCoQmyP7IGexG+URLNZzhb9mJu7y3J4yUZA8BOTBH9hWhB8bLGiFn8OViyR6ND5KjQm1Qlj8W3 X-Received: by 10.180.74.201 with SMTP id w9mr5045775wiv.17.1415367071922; Fri, 07 Nov 2014 05:31:11 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id dc8sm2076866wib.7.2014.11.07.05.31.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Nov 2014 05:31:10 -0800 (PST) Message-ID: <545CC99B.1010302@multiplay.co.uk> Date: Fri, 07 Nov 2014 13:31:07 +0000 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andriy Gapon , Borja Marcos Subject: Re: ZFS bug: was creating ZIL ignores vfs.zfs.min_auto_ashift, should be ZIL sets improper ashift with AHCI controllers References: <9C91F97841BC4347910F206618BAA3BB9AF327D1@PAIMAIL.pai.local> <545B76EF.6050709@multiplay.co.uk> <21D2A3A9-B6C1-458F-B17F-480251E999AE@sarenet.es> <545BE3E0.4030203@multiplay.co.uk> <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es> <545C9552.30207@multiplay.co.uk> <545CB43E.6040901@FreeBSD.org> In-Reply-To: <545CB43E.6040901@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 13:31:20 -0000 On 07/11/2014 11:59, Andriy Gapon wrote: > On 07/11/2014 11:48, Steven Hartland wrote: >> On 07/11/2014 07:31, Borja Marcos wrote: >>> snip... >>> >>> You are right! >>> >>> This time I had not altered min_auto_ashift but I had added a quirk to >>> ata_da.c. So it >>> correctly used the quirk sector size to adjust ashift. >>> >>> Seems the bug should be "improper cache file generation for a pool used for >>> boot". I'll >>> see if I can run some more tests. >>> >> I believe the attached is the correct fix, but I've asked upstream as this test >> was explicitly added ages ago. > It could be that this problem is of no interest / relevance to the illumos > upstream as they have more restrictions on how a root pool can be configured. I > am not sure if they allow slog devices for root pools. > illumos does indeed have the following restrictions for root pools according to zfs_ioc_vdev_add * Concatenated devices are not supported * Intent log device is not supported So your right but I'm still curious if there are any reasons why we shouldn't sync the zpool.cache file for the root pool as that seems independent to this? The only thing I can think of is that it was an optimisation but this would still break things like a reguid. Regards Steve