From owner-svn-src-all@freebsd.org Thu Oct 17 15:08:25 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EDC5F1548B5; Thu, 17 Oct 2019 15:08:25 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vCGd3Yyjz4KCC; Thu, 17 Oct 2019 15:08:25 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id x9HF8M4d047179 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 17 Oct 2019 08:08:22 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id x9HF8MCf047178; Thu, 17 Oct 2019 08:08:22 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Thu, 17 Oct 2019 08:08:22 -0700 From: Gleb Smirnoff To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r353635 - in head/sys: netinet netinet6 Message-ID: <20191017150822.GY4086@FreeBSD.org> References: <201910160911.x9G9BonH076337@repo.freebsd.org> <20191016165722.GU4086@FreeBSD.org> <138998a2-b304-fbe3-065d-e1df0a09af14@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <138998a2-b304-fbe3-065d-e1df0a09af14@selasky.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 46vCGd3Yyjz4KCC X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.70 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.70)[-0.701,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Oct 2019 15:08:26 -0000 On Wed, Oct 16, 2019 at 10:46:44PM +0200, Hans Petter Selasky wrote: H> > as far as I remember I was against this changeset and I had H> > several other developers agreed that this should be fixed in H> > different way. Why did you proceed with checking it in? :( H> H> Hi Gleb, H> H> This issue has been discussed in-depth at various transport meetings and H> we have agreed on a solution. Is the list of people who agreed longer than "Reviewed by" list? H> Are you seeing something broken as of this patch? As I already explained, first, we are dropping absolutely legitimate packets. At the time of arrival there were nothing wrong about them. This is idelogically wrong from viewpoint of abstract network stack. Second, the problem should be fixed in a different way: when we put packets on the queue, we should take all important values out of the ifnet and store them on queue entry. -- Gleb Smirnoff