Date: Sun, 27 Feb 2011 22:00:26 GMT From: Craig Leres <leres@ee.lbl.gov> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/154519: [PATCH] net/beacon: update to 1.4 Message-ID: <201102272200.p1RM0Qso018912@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/154519; it has been noted by GNATS.
From: Craig Leres <leres@ee.lbl.gov>
To: Sahil Tandon <sahil@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/154519: [PATCH] net/beacon: update to 1.4
Date: Sun, 27 Feb 2011 13:55:43 -0800
This is a multi-part message in MIME format.
--------------040902010902070203050207
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/27/11 12:24, Sahil Tandon wrote:
> Also, why do you remove the definition of USE_RC_SUBR?
Beacon 1.4 installs a rc.d script when it detects FreeBSD. (Note that
etc/rc.d/beacon was added to pkg-plist.)
> Why do you
> explicitly set DISTNAME to its default of ${PORTNAME}-${PORTVERSION}?
That's a mistake. And it turns out MASTER_SITES was broken. Finally, the
IPV6 option needed to be in caps.
> Why do you remove the EXTRA_PATCHES?
They are incorporated into beacon 1.4.
> Are docs no longer distributed by
> the upstream?
There is a README; I put it back.
> A little more clarity on the rationale for your various
> edits would be helpful.
One goal of the beacon 1.4 release was to make it "FreeBSD ports clean."
I've attached a new set of patches. Note that the files directory still
needs to be removed.
Craig
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk1qyF8ACgkQWxlAhAje3JsPuACeMCgaWHyvvqsJ4q6TsIpJCZnR
tJEAn0zlhq7I06oM1VSGWIG/x3l3nUfG
=Hy92
-----END PGP SIGNATURE-----
--------------040902010902070203050207
Content-Type: text/plain;
name="patch-Makefile.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-Makefile.txt"
--- Makefile.orig 2011-02-04 19:44:24.000000000 -0800
+++ Makefile 2011-02-04 19:39:55.000000000 -0800
@@ -2,44 +2,34 @@
# Date created: 26 February 2004
# Whom: Janos.Mohacsi@bsd.hu
#
-# $FreeBSD: ports/net/beacon/Makefile,v 1.22 2010/12/15 22:44:42 pgollucci Exp $
+# $FreeBSD$
#
PORTNAME= beacon
-PORTVERSION= 1.3
-PORTREVISION= 4
+PORTVERSION= 1.4
CATEGORIES= net perl5 mbone ipv6
MASTER_SITES= http://dast.nlanr.net/Projects/Beacon/releases/
+DISTNAME= ${PORTNAME}-${PORTVERSION}
MAINTAINER= janos.mohacsi@bsd.hu
COMMENT= Beacon active measurement tool to monitor multicast
BUILD_DEPENDS= ${SITE_PERL}/Net/Domain.pm:${PORTSDIR}/net/p5-Net
-RUN_DEPENDS= ${SITE_PERL}/Net/Domain.pm:${PORTSDIR}/net/p5-Net
+RUN_DEPENDS= ${BUILD_DEPENDS}
WWW_DIR?= ${PREFIX}/www/
PLIST_SUB+= VERSION=${PORTVERSION}
USE_PERL5= yes
USE_AUTOTOOLS= autoconf
-USE_RC_SUBR= beacon
-.ifdef(WITHOUT_IPV6)
CONFIGURE_ARGS=
+
+OPTIONS= IPv6 "Enable IPv6 PTR lookups" off
+
+.ifdef(WITHOUT_IPV6)
.else
-#enable IPv6 name lookup, and sending IPv6 multicast
BUILD_DEPENDS+= ${SITE_PERL}/${PERL_ARCH}/Socket6.pm:${PORTSDIR}/net/p5-Socket6
-EXTRA_PATCHES+= ${FILESDIR}/extra-patch-src_beacon.in
CONFIGURE_ARGS+= --enable-ipv6
.endif
-.include <bsd.port.pre.mk>
-
-post-install:
- @${ECHO} "Sample config installed at ${PREFIX}/etc/beacon.conf.sample"
- @${ECHO} "Copy the customised version to ${PREFIX}/etc/beacon.conf"
-.ifndef(NOPORTDOCS)
- @${MKDIR} ${DOCSDIR}/
- @${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}/
-.endif
-
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>
--------------040902010902070203050207
Content-Type: text/plain;
name="patch-distinfo.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-distinfo.txt"
--- distinfo.orig 2011-02-04 19:44:33.000000000 -0800
+++ distinfo 2011-02-04 19:35:11.000000000 -0800
@@ -1,3 +1,2 @@
-MD5 (beacon-1.3.tar.gz) = e01b0de6b0d7d01ea51bad799b147d8c
-SHA256 (beacon-1.3.tar.gz) = ce036fb927045c6270cf3fa504b5988856ed4cd975aefd3f23a8e6c076ba32b6
-SIZE (beacon-1.3.tar.gz) = 411823
+SHA256 (beacon-1.4.tar.gz) = 0143199f2405a3c93e9f0b5d7ebf61b4877ac664f5209d180b1dbd72ce43f673
+SIZE (beacon-1.4.tar.gz) = 464268
--------------040902010902070203050207
Content-Type: text/plain;
name="patch-pkg-plist.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="patch-pkg-plist.txt"
--- pkg-plist.orig 2011-02-04 19:44:39.000000000 -0800
+++ pkg-plist 2011-01-14 16:32:28.000000000 -0800
@@ -10,5 +10,4 @@
@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Net
bin/beacon
etc/beacon.conf.sample
-%%PORTDOCS%%%%DOCSDIR%%/README
-%%PORTDOCS%%@dirrm %%DOCSDIR%%
+etc/rc.d/beacon
--------------040902010902070203050207
Content-Type: application/octet-stream;
name="patch-Makefile.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="patch-Makefile.txt.sig"
iEYEABECAAYFAk1qyF8ACgkQWxlAhAje3JuMmgCePhLyrQ/nsp9vZiQ4//0FFMhSfBQAn1fy
60ONz3i58jFQiY/YL6frEHlm
--------------040902010902070203050207
Content-Type: application/octet-stream;
name="patch-distinfo.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="patch-distinfo.txt.sig"
iEYEABECAAYFAk1qyF8ACgkQWxlAhAje3JvFWgCeK830Vc3nnNJQn5mE5Lu2Fq680zYAnj0i
4CXhiBYHyDf/rh9Y2D7X5esN
--------------040902010902070203050207
Content-Type: application/octet-stream;
name="patch-pkg-plist.txt.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="patch-pkg-plist.txt.sig"
iEYEABECAAYFAk1qyF8ACgkQWxlAhAje3Jud8ACePUBFQQ3CPJV51WzirwR6mLw8cjkAni1x
8uhGeohYwdFTqx2+2EetVIGb
--------------040902010902070203050207--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102272200.p1RM0Qso018912>