From owner-svn-src-all@freebsd.org Fri Apr 12 20:03:39 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 419F21584E7C; Fri, 12 Apr 2019 20:03:39 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yw1-f66.google.com (mail-yw1-f66.google.com [209.85.161.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C657D8A5BA; Fri, 12 Apr 2019 20:03:38 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yw1-f66.google.com with SMTP id z9so3822394ywd.6; Fri, 12 Apr 2019 13:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X6NDRV5pJO06b5BWHorTbbR2N6Hw/fi29QZrMYBgIjc=; b=ahMxWbfL0h3oOiwjaGQdPSt/OZEG24XsNFuew4QGhW5OSt5/wJs7GJL1D5RefhkpYN 24DSv0aU+5ESYeHhDwxrWt9kAvCFW8f8Nn0iT6LFJpVbg5NjD9IcN0ZH2sRBAxkPsSOk 5/B6o6JVHEEkLj5Bl16fHZSc3Rkq+3dgzLVqSvJS31ByqXV8jFtkFm/4KSe2Vk9Mmf/h q+V9nPFWlkCeNmNvJ1ooSH1ehI4+/pdVnhq7hhhyJ3Em5ras4dp0A9I3E+eVv2YYd8PM ugRl2knVvTIT4XIWiDrvu85O9Vg06f1wBD4MYEfaKUEStXXh/5qPi3V2nuFahREbStiw tpig== X-Gm-Message-State: APjAAAUNzmnLTqXrLQ6alwiKG2/5is8gfFucFCdpsJldDcxQaihxw+Ho 1YDNx4UgLk6pgcafH27QyY7B1lw3IrA2U6rl7BQ= X-Google-Smtp-Source: APXvYqzd39/FjJWwmTYqxqlg9Q2TiWaQ1HVn2u3yBhbSZ7H1uUxxMQotrrvhDuVf12UhnUuvHWphLiVMArFlHB2bpNU= X-Received: by 2002:a81:4f10:: with SMTP id d16mr46525924ywb.184.1555098942697; Fri, 12 Apr 2019 12:55:42 -0700 (PDT) MIME-Version: 1.0 References: <201904121835.x3CIZETP017600@repo.freebsd.org> <5DF1F115-692D-48B7-A52C-AD1BF5E738E5@gmail.com> In-Reply-To: <5DF1F115-692D-48B7-A52C-AD1BF5E738E5@gmail.com> From: Li-Wen Hsu Date: Sat, 13 Apr 2019 04:55:30 +0900 Message-ID: Subject: Re: svn commit: r346160 - head/usr.bin/mandoc To: Enji Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C657D8A5BA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.959,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 20:03:39 -0000 On Sat, Apr 13, 2019 at 3:53 AM Enji Cooper wrote: > > > > On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu wrote: > > > > Author: lwhsu > > Date: Fri Apr 12 18:35:14 2019 > > New Revision: 346160 > > URL: https://svnweb.freebsd.org/changeset/base/346160 > > > > Log: > > Suppress old gcc warning about null format string > > > > This is workaround to make head build on gcc using architectures > > > > Sponsored by: The FreeBSD Foundation > > MFC-with: r346149 > > > > Modified: > > head/usr.bin/mandoc/Makefile > > > > Modified: head/usr.bin/mandoc/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/usr.bin/mandoc/Makefile Fri Apr 12 18:13:57 2019 (= r346159) > > +++ head/usr.bin/mandoc/Makefile Fri Apr 12 18:35:14 2019 (= r346160) > > @@ -97,6 +97,8 @@ SRCS=3D ${LIB_SRCS} \ > > WARNS?=3D 3 > > CFLAGS+=3D -DHAVE_CONFIG_H \ > > -I${SRCTOP}/lib/libopenbsd/ > > +# This can be removed after swtiching to newer gcc > > +CFLAGS.gcc+=3D -Wno-format > > LIBADD=3D openbsd z > > > > .include > > Couldn=E2=80=99t this be fixed upstream and pulled back in, inste= ad of ignoring the warning? That's possible, but I don't know how much of the possibility that upstream is willing to fix a warning that only occurs in old versions of gcc, and it looks a false positive to me. I am here to put a band-aid first. Best, Li-Wen