From owner-cvs-all Fri Jan 31 14:17:59 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 18C1337B406 for ; Fri, 31 Jan 2003 14:17:56 -0800 (PST) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9588943F43 for ; Fri, 31 Jan 2003 14:17:54 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 7298 invoked from network); 31 Jan 2003 22:18:03 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 31 Jan 2003 22:18:03 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h0VMHqUT073219; Fri, 31 Jan 2003 17:17:52 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Fri, 31 Jan 2003 17:17:58 -0500 (EST) From: John Baldwin To: Julian Elischer Subject: RE: cvs commit: src/sys/kern subr_trap.c Cc: "Tim J. Robbins" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 31-Jan-2003 Julian Elischer wrote: >> It's working for some value of working. The fact is, given the subtle >> bug that broke profiling and the fact that the same type of bug is >> evident in other places and the fact that it was only tested on i386 >> UP, I feel that the probability is high that there are similar bugs in >> this commit that we just haven't hit yet and that could be found with >> a good review. > > So what's stopping you? I am quite busy with other work at the moment. Notice that I'm not committing sweeping changes to the kernel since I don't have adequate time to test/review them. The only thing I am committing are small MFC's of things that have been well tested. >> > What I want to know is where did you hear other people pointing out >> > that "thread_statclock() has a similar problem"? >> >> I saw a note on IRC in my scrollback (I wasn't present at the time) that >> it might have a similar problem and looked at the code in question along >> with the diff's and annotates of previous versions to verify that it was >> an actual bug. > > OK so what we are saying is that to be a developer we need to be on IRC? > if this is so, then the project should supply an IRC server for > us to use. No, I'm not saying that at all. People have private conversations all the time whether it be on IRC, in private e-mail, or at lunch at the In-N-Out burger in San Ramon, CA. When I saw the mention of a possible bug, I researched it (aka review) and then brought it to your attention. >> > I seem to only be seeing a part of the discussion here.. >> > people keep refering to error reports by people that I have not seen. >> >> These are bugs that you would hopefully be catching if you were reviewing >> the things that get committed with your stamp of approval on them. > > I object to your continual comment that it was committed with my stamp > of aproval. Then don't let people commit things with your stamp on it if it shouldn't be there. If someone was going around forging checks in your name and you didn't do anything to stop it would you just hope that the money didn't leave your checking account? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message