From owner-svn-src-all@FreeBSD.ORG Sat Mar 13 21:13:52 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AB3611065700; Sat, 13 Mar 2010 21:13:52 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6A0D18FC25; Sat, 13 Mar 2010 21:13:52 +0000 (UTC) Received: by pwj4 with SMTP id 4so1473870pwj.13 for ; Sat, 13 Mar 2010 13:13:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jSnK9l9+yaNO6wr9evNGfyQW7lLtXzUh8XdQSfNN8O8=; b=dHLjKWVfYQS34wdqCn+/onJjfpJXyGyMlsu8lKhz8l0Fz/CwvfnfVjybFJYnToqwLE q7NNwEruOvpxHwSbdbLC0rAXIG+V+LexPib8rzxzomlKRdFeEbCXA2PGC+C9L+kgMs7q ykHaTwD2Fe94qtPxaQwAYGlxq40SLomYeYE8k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=nY0DV9Yhx3DTxhWYnQkO4/avfs7D32GaO6MtljzoghgwL6LI67uTRKPMkpfMiAzGjP bhx8QTzrawPUFO3QGpuIXj3+oSTp5cQuL9uyJ6nsWRq6PF8ObbN3Dx8F0jNqlLn9LS2b sQG0fX5hZsJ3FJk/z6n/7S9v/eqVNqsTkUNuk= MIME-Version: 1.0 Received: by 10.143.24.17 with SMTP id b17mr2270532wfj.266.1268514831858; Sat, 13 Mar 2010 13:13:51 -0800 (PST) In-Reply-To: <201003131108.o2DB8vmu001454@svn.freebsd.org> References: <201003131108.o2DB8vmu001454@svn.freebsd.org> Date: Sat, 13 Mar 2010 13:13:51 -0800 Message-ID: <7d6fde3d1003131313l3559b6dbt1566fb23be150408@mail.gmail.com> From: Garrett Cooper To: Bruce Cran Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205118 - head/sbin/sysctl X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 21:13:52 -0000 On Sat, Mar 13, 2010 at 3:08 AM, Bruce Cran wrote: > Author: brucec > Date: Sat Mar 13 11:08:57 2010 > New Revision: 205118 > URL: http://svn.freebsd.org/changeset/base/205118 > > Log: > =A0Free the memory allocated via strdup. > > =A0PR: =A0 =A0 =A0 =A0 =A0 bin/113881 > =A0Submitted by: Alexander Drozdov =A0dzal_mail mtu-net.ru > =A0Approved by: =A0rrs (mentor) > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sbin/sysctl/sysctl.c > > Modified: head/sbin/sysctl/sysctl.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sbin/sysctl/sysctl.c =A0 Sat Mar 13 11:06:47 2010 =A0 =A0 =A0 = =A0(r205117) > +++ head/sbin/sysctl/sysctl.c =A0 Sat Mar 13 11:08:57 2010 =A0 =A0 =A0 = =A0(r205118) > @@ -382,6 +382,7 @@ S_timeval(int l2, void *p) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (*p2 =3D=3D '\n') > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*p2 =3D '\0'; > =A0 =A0 =A0 =A0fputs(p1, stdout); > + =A0 =A0 =A0 free(p1); > =A0 =A0 =A0 =A0return (0); > =A0} strdup(3) can fail in that section of code, thus the fputs(3) could segfault: [gcooper@bayonetta ~]$ cat foo.c #include #include int main(void) { char *foo =3D NULL; fputs(foo, stdout); free(foo); return 0; } [gcooper@bayonetta ~]$ gcc -o foo foo.c [gcooper@bayonetta ~]$ ./foo Segmentation fault: 11 (core dumped) Could a... if (p1 =3D=3D NULL) ... be added before the fputs(3) please? Thanks, -Garrett