From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Nov 13 12:30:23 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 24C2416A4CE for ; Sat, 13 Nov 2004 12:30:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 070E543D2F for ; Sat, 13 Nov 2004 12:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) iADCUMlj059900 for ; Sat, 13 Nov 2004 12:30:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iADCUMGb059861; Sat, 13 Nov 2004 12:30:22 GMT (envelope-from gnats) Resent-Date: Sat, 13 Nov 2004 12:30:22 GMT Resent-Message-Id: <200411131230.iADCUMGb059861@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Zahemszky Gabor Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC95316A4CE for ; Sat, 13 Nov 2004 12:24:27 +0000 (GMT) Received: from zahemszky.hu (103.99-182-adsl-pool.axelero.hu [81.182.99.103]) by mx1.FreeBSD.org (Postfix) with ESMTP id D847543D46 for ; Sat, 13 Nov 2004 12:24:26 +0000 (GMT) (envelope-from zgabor@zahemszky.hu) Received: from zahemszky.hu (localhost [127.0.0.1]) by Picasso.Zahemszky.HU (8.13.1/8.13.1) with ESMTP id iADCOHN2001460 for ; Sat, 13 Nov 2004 13:24:17 +0100 (CET) (envelope-from zgabor@zahemszky.hu) Received: (from zgabor@localhost) by zahemszky.hu (8.13.1/8.13.1/Submit) id iADCOGVo001459; Sat, 13 Nov 2004 13:24:16 +0100 (CET) (envelope-from zgabor) Message-Id: <200411131224.iADCOGVo001459@zahemszky.hu> Date: Sat, 13 Nov 2004 13:24:16 +0100 (CET) From: Zahemszky Gabor To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/73894: Missing RUN_DEPENDS in mail/sylpheed with [PATCH] X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Zahemszky Gabor List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Nov 2004 12:30:23 -0000 >Number: 73894 >Category: ports >Synopsis: Missing RUN_DEPENDS in mail/sylpheed with [PATCH] >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Nov 13 12:30:22 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Zahemszky Gabor >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD zahemszky.hu 5.3-STABLE FreeBSD 5.3-STABLE #0: Fri Nov 5 13:16:12 CET 2004 root@Picasso.Zahemszky.HU:/usr/obj/usr/src/sys/PICASSO i386 >Description: The mail/sylpheed (and maybe the mail/sylpheed-claws) port is missing some RUN_DEPEND. In the file src/mimeview.c, in the mimeview_view_file routine, there are the next lines: static gchar *default_image_cmdline = "display '%s'"; static gchar *default_audio_cmdline = "play '%s'"; static gchar *default_html_cmdline = DEFAULT_BROWSER_CMD; static gchar *mime_cmdline = "metamail -d -b -x -c %s '%s'"; and in src/defs.h: #define DEFAULT_BROWSER_CMD "mozilla -remote 'openURL(%s, new_window)'" As "display" is part of graphics/ImageMagick, "play" is part of audio/sox, "mozilla" is (of course) www/mozilla (or maybe mozilla-devel), and "metamail" is mail/metamail, I think these dependencies are missing from the Makefile. >How-To-Repeat: Look into the source, or try view some image, play some music (etc) from a running sylpheed. >Fix: Put these RUN_DEPENDS into the Makefile: RUN_DEPENDS+= ${LOCALBASE}/bin/display:${PORTSDIR}/graphics/ImageMagick RUN_DEPENDS+= ${LOCALBASE}/bin/play:${PORTSDIR}/audio/sox RUN_DEPENDS+= ${LOCALBASE}/bin/metamail:${PORTSDIR}/mail/metamail RUN_DEPENDS+= ${X11BASE}/bin/mozilla:${PORTSDIR}/www/mozilla Or something like these, I think, there is a better form to mozilla, but I don't know. And I think, it would be better to use these with some intelligence, eg: #if defined(WITH_IMAGEMAGICK) around in the Makefile - and of course in the src/mimeview.c file. I think, it would be better, to use _only_ metamail, and the user can install xv/ImageMagick/EOG/etc - what she wants. >Release-Note: >Audit-Trail: >Unformatted: