From owner-svn-src-all@FreeBSD.ORG Sat Jan 21 05:52:57 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C015106564A; Sat, 21 Jan 2012 05:52:57 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail14.syd.optusnet.com.au (mail14.syd.optusnet.com.au [211.29.132.195]) by mx1.freebsd.org (Postfix) with ESMTP id D2B5C8FC0C; Sat, 21 Jan 2012 05:52:55 +0000 (UTC) Received: from c211-30-171-136.carlnfd1.nsw.optusnet.com.au (c211-30-171-136.carlnfd1.nsw.optusnet.com.au [211.30.171.136]) by mail14.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id q0L5qqLM029921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 21 Jan 2012 16:52:53 +1100 Date: Sat, 21 Jan 2012 16:52:52 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Eitan Adler In-Reply-To: Message-ID: <20120121164200.I2292@besplex.bde.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1597002112-1327125172=:2292" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Hiroki Sato , Bruce Evans , src-committers@FreeBSD.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 05:52:57 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1597002112-1327125172=:2292 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Fri, 20 Jan 2012, Eitan Adler wrote: > On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrote= : >> I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it.= =C2=A0Not all >> vendor code is in contrib. > > I'm sure this is a silly question, but why isn't this utility in a > contrib/ folder? Probably historical, but src/contrib/ still has little more than `file' and lukemftpd from NetBSD. I think those are there mainly because they got portabilized and complicated by their use of autoconfig, so they don't fit naturally in the BSD build framework any more. > [snip other fixes to the api] [for cpucontrol] >> I don't understand this code well enough to fix it. =C2=A0Fixing it requ= ires >> understanding whether the unused variable was unused because of another >> bug. =C2=A0Another bug seems likely here, since there is so much dead co= de. >> Or maybe I'm just confused, and the dead code is actually undead. =C2=A0= It >> is complicated enough for this to be unclear. > > I did not just rely on the compiler - I went through the code manually > to ensure it was correct. It can take too long to see correctness for an apparently-simple change. Bruce --0-1597002112-1327125172=:2292--