From owner-p4-projects@FreeBSD.ORG  Thu Aug 26 20:35:56 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E1F301065698; Thu, 26 Aug 2010 20:35:55 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C7D01065693
	for <perforce@freebsd.org>; Thu, 26 Aug 2010 20:35:55 +0000 (UTC)
	(envelope-from trasz@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 3194A8FC14
	for <perforce@freebsd.org>; Thu, 26 Aug 2010 20:35:55 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id o7QKZtoT065818
	for <perforce@freebsd.org>; Thu, 26 Aug 2010 20:35:55 GMT
	(envelope-from trasz@freebsd.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id o7QKZtjV065815
	for perforce@freebsd.org; Thu, 26 Aug 2010 20:35:55 GMT
	(envelope-from trasz@freebsd.org)
Date: Thu, 26 Aug 2010 20:35:55 GMT
Message-Id: <201008262035.o7QKZtjV065815@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	trasz@freebsd.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 182939 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Aug 2010 20:35:56 -0000

http://p4web.freebsd.org/@@182939?ac=10

Change 182939 by trasz@trasz_victim on 2010/08/26 20:35:14

	Update TODO.

Affected files ...

.. //depot/projects/soc2009/trasz_limits/TODO#27 edit

Differences ...

==== //depot/projects/soc2009/trasz_limits/TODO#27 (text+ko) ====

@@ -9,15 +9,12 @@
  - locked memory usage (RUSAGE_MEMLOCK), in megabytes
  - resident set size (physical memory usage) (RUSAGE_RSS), in megabytes
  - stack size (RUSAGE_STACK), in megabytes,
+ - number of file descriptors (RUSAGE_NOFILE)
+ - swap usage (RUSAGE_SWAP), in megabytes
+ - amount of memory consumed by socket buffers (RUSAGE_SBSIZE), in megabytes
 
 Limits to do:
 
-Milestone 1:
-
- - swap usage (RUSAGE_SWAP), in megabytes
- - number of file descriptors (RUSAGE_NOFILE)
- - amount of memory consumed by socket buffers (RUSAGE_SBSIZE), in megabytes
-
 Milestone 2:
 
  - number of kernel-visible threads (RUSAGE_NTHR)
@@ -68,6 +65,22 @@
    Also, try to figure out what's going on with 'intr' p_flag - checking for P_SYSTEM
    didn't really work for that process.
 
+ - Right now, the whole containers stuff is under a single mutex.  This is internal
+   to containers, i.e. the API consumers don't need to care, thus it's easy to change.
+
+   I'd need to run benchmarks first, but two strategies come to mind:
+
+   1. Replace container_lock with rmlock, protecting the container hierarchy.  The lock
+      would be acquired for write in operations changing the hierarchy, and for read
+      for all other operations.  When locked for read, the counters would be accessed
+      using atomic instructions.
+
+   2. Replace single container_lock with individual per-container mutexes.
+
+ - RUSAGE_NOFILE accounts for size of file descriptor table, rather than the number
+   of file descriptors.  This shouldn't be a problem, but might be worth remembering
+   about.
+
 HRL-specific issues:
 
  - Bring back per-group limits.