From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 21 16:40:29 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B15D616A4CE for ; Thu, 21 Apr 2005 16:40:29 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7063443D39 for ; Thu, 21 Apr 2005 16:40:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3LGeR8w027147 for ; Thu, 21 Apr 2005 16:40:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3LGeQoV027146; Thu, 21 Apr 2005 16:40:26 GMT (envelope-from gnats) Resent-Date: Thu, 21 Apr 2005 16:40:26 GMT Resent-Message-Id: <200504211640.j3LGeQoV027146@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Fernando Schapachnik Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10C0916A4CE for ; Thu, 21 Apr 2005 16:36:39 +0000 (GMT) Received: from relay2.mecon.ar (relay2.mecon.gov.ar [168.101.16.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id D7D5543D58 for ; Thu, 21 Apr 2005 16:36:36 +0000 (GMT) (envelope-from fpscha@mecon.gov.ar) Received: from racing.mecon.ar (racing.mecon.gov.ar [168.101.133.15]) by relay2.mecon.ar (8.12.11/8.12.11) with ESMTP id j3LGaGls080128; Thu, 21 Apr 2005 13:36:16 -0300 (ART) (envelope-from fpscha@mecon.gov.ar) Received: from racing.mecon.ar (meyosp.mecon.gov.ar [10.11.0.149]) by racing.mecon.ar (8.12.8p2/8.12.8) with ESMTP id j3LGaGls039075; Thu, 21 Apr 2005 13:36:16 -0300 (ART) (envelope-from fpscha@mecon.gov.ar) Received: from bal740r0.mecon.gov.ar (bal740r0.mecon.ar [10.11.1.11]) by racing.mecon.ar (8.12.8p2/8.12.8) with ESMTP id j3LGaGK7039071; Thu, 21 Apr 2005 13:36:16 -0300 (ART) (envelope-from fpscha@mecon.gov.ar) Received: from bal740r0.mecon.gov.ar (localhost [127.0.0.1]) by bal740r0.mecon.gov.ar (8.13.1/8.13.1) with ESMTP id j3LGaGEx002180; Thu, 21 Apr 2005 13:36:16 -0300 (ART) (envelope-from fpscha@bal740r0.mecon.gov.ar) Received: (from fpscha@localhost) by bal740r0.mecon.gov.ar (8.13.1/8.12.11/Submit) id j3LGa6cs002179; Thu, 21 Apr 2005 13:36:06 -0300 (ART) (envelope-from fpscha) Message-Id: <200504211636.j3LGa6cs002179@bal740r0.mecon.gov.ar> Date: Thu, 21 Apr 2005 13:36:06 -0300 (ART) From: Fernando Schapachnik To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: spe@bsdfr.org Subject: ports/80217: FreeVRRPd doesn't allow to specify advertisement interval X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Fernando Schapachnik List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2005 16:40:29 -0000 >Number: 80217 >Category: ports >Synopsis: FreeVRRPd doesn't allow to specify advertisement interval >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Apr 21 16:40:26 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Fernando Schapachnik >Release: FreeBSD 5.3-RELEASE-p5 i386 >Organization: >Environment: System: FreeBSD bal740r0.mecon.gov.ar 5.3-RELEASE-p5 FreeBSD 5.3-RELEASE-p5 #3: Tue Jan 18 12:25:08 ART 2005 root@bal740r0.mecon.gov.ar:/usr/obj/usr/src/sys/BAL740R0 i386 >Description: FreeVRRPd (net/freevrrpd) doesn't allow to specify the "advertisement interval". Such interval is interesting because the "master down interval" is computed (per RFC) as 3*advertisement interval+skew. Setting it to higher values allows to avoid some false positives that can arise from very transient network failures. If you are starting and stopping services, and switching databases via VRRP, you might not want be really sure that the master is down. >How-To-Repeat: >Fix: The following patch adds the configuration variable advinterval, which controls said interval. --- vrrp_conf.c.orig Thu Apr 21 13:23:07 2005 +++ vrrp_conf.c Thu Apr 21 11:13:29 2005 @@ -231,6 +231,11 @@ vr->priority = atoi(temp[0]); vrrp_conf_freeargs(temp); } + if (!strcmp(option, "advinterval")) { + temp = vrrp_conf_split_args(arg, ','); + vr->adv_int = atoi(temp[0]); + vrrp_conf_freeargs(temp); + } if (!strcmp(option, "password")) { temp = vrrp_conf_split_args(arg, ','); vr->password = (char *)calloc(8, 1); --- freevrrpd.conf.sample.orig Thu Apr 21 13:31:45 2005 +++ freevrrpd.conf.sample Thu Apr 21 13:34:54 2005 @@ -33,6 +33,13 @@ # don't, all BACKUP VRRP packets will be rejected. password = vrid1 +# advertisement interval (seconds). this is the time between advertisements. +# also indirectly controls "master timeout" (master timeout = 3*advertisement +# interval+skew, see RFC 3768 for details), which is the number of seconds +# to wait before declaring the master dead. be sure to set the same value in +# both master and slave. defaults to 1 second. +advinterval = 1 + # now, you can specify a script name to execute when this host became master # of this VRID masterscript = "/usr/local/bin/master_script.sh" >Release-Note: >Audit-Trail: >Unformatted: