From owner-svn-ports-head@FreeBSD.ORG Wed May 27 17:39:47 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9EF5D9EA for ; Wed, 27 May 2015 17:39:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7A906ADD for ; Wed, 27 May 2015 17:39:47 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t4RHdlb1099948 for ; Wed, 27 May 2015 17:39:47 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t4RHdlrf099945 for svn-ports-head@freebsd.org; Wed, 27 May 2015 17:39:47 GMT (envelope-from bdrewery) Received: (qmail 45249 invoked from network); 27 May 2015 12:39:45 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 27 May 2015 12:39:45 -0500 Message-ID: <55660165.3050106@FreeBSD.org> Date: Wed, 27 May 2015 12:39:49 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Mikhail Teterin , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r387637 - in head/devel/tcllib: . files References: <201505271719.t4RHJXY6010274@svn.freebsd.org> In-Reply-To: <201505271719.t4RHJXY6010274@svn.freebsd.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 17:39:47 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/27/2015 12:19 PM, Mikhail Teterin wrote: > Author: mi > Date: Wed May 27 17:19:32 2015 > New Revision: 387637 > URL: https://svnweb.freebsd.org/changeset/ports/387637 >=20 > Log: > Rely on critcl port to provide compiled implementations of the > modules, where available. > =20 > PR: 195863 > Approved by: maintainer (blanket) >=20 > Added: > head/devel/tcllib/files/patch-jpeg (contents, props changed) > head/devel/tcllib/files/patch-json (contents, props changed) > head/devel/tcllib/files/patch-tests (contents, props changed) > Modified: > head/devel/tcllib/Makefile > head/devel/tcllib/pkg-plist >=20 > Modified: head/devel/tcllib/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/devel/tcllib/Makefile Wed May 27 16:26:13 2015 (r387636) > +++ head/devel/tcllib/Makefile Wed May 27 17:19:32 2015 (r387637) > @@ -3,6 +3,7 @@ > =20 > PORTNAME=3D tcllib > PORTVERSION=3D 1.17 > +PORTREVISION=3D 1 > CATEGORIES=3D devel tcl > =20 > MAINTAINER=3D tcltk@FreeBSD.org > @@ -13,6 +14,8 @@ LICENSE_NAME=3D Tcl/Tk License > LICENSE_FILE=3D ${WRKSRC}/license.terms > LICENSE_PERMS=3D dist-mirror dist-sell pkg-mirror pkg-sell auto-accept= > =20 > +BUILD_DEPENDS=3D critcl:${PORTSDIR}/devel/critcl =2E.. > do-install: > cd ${WRKSRC} && ${TCLSH} ./installer.tcl ${INSTALL_ARGS} > + ${RM} ${WRKSRC}/modules/tcllibc/license.terms > + ${CP} -Rp ${WRKSRC}/modules/tcllibc ${STAGEDIR}${PREFIX}/lib/tcllib/ =2E.. > +lib/tcllib/tcllibc/%%BINARCH%%/tcllibc.so Bundling libraries is bad. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/bundle= d-libs.html It will also confuse pkg unless BUNDLE_LIBS=3Dyes is added. Can tcllib not use critcl from its own package? --=20 Regards, Bryan Drewery --3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVZgFlAAoJEDXXcbtuRpfPqxoIANVmqSf7IkX1tLxtwAYWd8DV X1qUC/v52mdsu1AXdorofkUmStcdCO3kfBYL3eUguz/0U1MVLLDyYUM31lCxgjwk 1QUxbRnZsECPqYPqcGf7mlGnJZDjCUDGVDx0Hv1Iy1495Mvg7qqbgUW+hQLiRc5a Dci7qEDRbDivjw3L+uQTFhgC/rt5PwMyQ1oSnnMD6mPAG/nshzZiYHM+MtS8g0ro jyvC0Jz6raAXFWhgnj1E4xsISkEwW2mzAriJTCxmqY4+ObZdSDyucZ/2djDnd9Jf ZWRa/++1ypWN0f7RQYO1QWQhm42F0AjC2xmfo1zXweWw+yI/UZT+70HGE3njBOE= =WwU+ -----END PGP SIGNATURE----- --3qIuaSvlg3XgifAKMhgkUVHXTSGpqFUlT--