Date: Fri, 1 Jun 2018 16:20:42 +0000 (UTC) From: Mathieu Arnold <mat@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r471270 - head/Mk/Scripts Message-ID: <201806011620.w51GKg2A004178@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mat Date: Fri Jun 1 16:20:42 2018 New Revision: 471270 URL: https://svnweb.freebsd.org/changeset/ports/471270 Log: SC2091: Remove surrounding $() to avoid executing output. ShellCheck has detected that you have a command that just consists of a command substitution. This is typically done in order to try to get the shell to execute a command, because $(..) does indeed execute commands. However, it's also replaced by the output of that command. PR: 227109 Submitted by: mat Sponsored by: Absolight Modified: head/Mk/Scripts/qa.sh (contents, props changed) Modified: head/Mk/Scripts/qa.sh ============================================================================== --- head/Mk/Scripts/qa.sh Fri Jun 1 16:20:39 2018 (r471269) +++ head/Mk/Scripts/qa.sh Fri Jun 1 16:20:42 2018 (r471270) @@ -657,7 +657,7 @@ proxydeps() { if listcontains ${dep_file} "${already}"; then continue fi - if $(pkg which -q ${dep_file} > /dev/null 2>&1); then + if pkg which -q ${dep_file} > /dev/null 2>&1; then dep_file_pkg=$(pkg which -qo ${dep_file}) # Check that the .so we need has a SONAME
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806011620.w51GKg2A004178>