From owner-freebsd-rc@FreeBSD.ORG Mon Apr 7 22:45:21 2014 Return-Path: Delivered-To: rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 73884FB6; Mon, 7 Apr 2014 22:45:21 +0000 (UTC) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx1.fisglobal.com", Issuer "VeriSign Class 3 Secure Server CA - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B34DDDF; Mon, 7 Apr 2014 22:45:20 +0000 (UTC) Received: from smarthost.fisglobal.com ([10.132.206.192]) by ltcfislmsgpa04.fnfis.com (8.14.5/8.14.5) with ESMTP id s37MjG40030077 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 7 Apr 2014 17:45:16 -0500 Received: from THEMADHATTER (10.242.181.54) by smarthost.fisglobal.com (10.132.206.192) with Microsoft SMTP Server id 14.3.174.1; Mon, 7 Apr 2014 17:45:13 -0500 From: Sender: Devin Teske To: , "'Hiroki Sato'" References: <04c901cf4c5d$a6a4a030$f3ede090$@FreeBSD.org> <0EBE3981-DC85-414D-85B8-7638F172040A@dataix.net> <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org> <20140331.121757.1100840815853109946.hrs@allbsd.org> <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org> In-Reply-To: <069f01cf4d14$0ff03980$2fd0ac80$@FreeBSD.org> Subject: RE: network.subr _aliasN handling Date: Mon, 7 Apr 2014 15:45:04 -0700 Message-ID: <0d7c01cf52b3$05a02a40$10e07ec0$@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQLl7DYKykKh8p6TvLmmwe5q3zMB9AI3LylbArF10lEChFGO0gGefDWYmJEw4XA= Content-Language: en-us X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.11.96, 1.0.14, 0.0.0000 definitions=2014-04-07_04:2014-04-07,2014-04-07,1970-01-01 signatures=0 Cc: jhellenthal@dataix.net, rc@FreeBSD.org, dteske@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2014 22:45:21 -0000 > -----Original Message----- > From: dteske@FreeBSD.org [mailto:dteske@FreeBSD.org] > Sent: Monday, March 31, 2014 12:05 PM > To: 'Hiroki Sato'; dteske@FreeBSD.org > Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org > Subject: RE: network.subr _aliasN handling > > > -----Original Message----- > > From: Hiroki Sato [mailto:hrs@FreeBSD.org] > > Sent: Sunday, March 30, 2014 8:18 PM > > To: dteske@FreeBSD.org > > Cc: jhellenthal@dataix.net; lists@jnielsen.net; rc@FreeBSD.org > > Subject: Re: network.subr _aliasN handling > > > > wrote > > in <04f701cf4c85$d1929680$74b7c380$@FreeBSD.org>: > > > > dt> But that wouldn't have deterred me. 30+ days of silence is > > dt> equivalent to acceptance -- just that I had noticed that the patch > > dt> could be expanded to include mdconfig{,2} scripts. Was going to > > dt> wait a full day to see if anyone balked at the expansion to > > dt> include mdconfig{,2} and then move forward. > > > > I like the direction in general, but there are two more comments: > > Committed change: http://svnweb.freebsd.org/changeset/base/264243 > > 1. sort(1) cannot be used [snip] > > Problem solved. Ended up beefing up the internal sort function (sort_lite()). Gave it some more options and regression tested it against several inputs and flags to always produce the same output as sort(1). > > 2. Please put the normalization part into a function and use it in > > get_if_var(), too. Adding another code for the same functionality > > makes maintenance difficult. Aforementioned enhancements to address that included in mentioned SVN r264243. -- Devin _____________ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.