From nobody Wed Aug 14 03:37:16 2024 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WkDTS4CHmz5SWW4; Wed, 14 Aug 2024 03:37:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WkDTS3hMbz4pFP; Wed, 14 Aug 2024 03:37:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723606636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TBo6l1L3IPJiesjPRM6MmHqSdZan3zxpLm2Gw9OYx94=; b=NH+u4Kv92l+JfqzV0ypdc8fuzmeHU5DLfVF6k+ZEqgDWJioaH2ICJ/RQroGUC4iGTNyX6d xTW6RDTjaqLZZbE+QpHNx/1Rjsf2XRIGewDdnvYFFwVbSKo8wasvpYIw37EmFj7jIP6t9o KrA9cDYebv6qeAqqts3i87KjiNV9Q0sZEd/dOTtbPa9b2kqrPRu2U11my0gISZcnDx1mDd GLc3vT7yLzP19gtmr+851chvs7krHqgq1oDHtQuWGK/s6d3Lgz2mHt/AXKaQwRRRlfpwoG 0DugAbRaWMFjRB16r0fuz/SDI3uLCbgRZCtw83eZonoWSxfriQESrapzeAaQfg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723606636; a=rsa-sha256; cv=none; b=jijAJgoGyQWPYVZ6SSty+sPZ/Eaa5aMWM0fdVvlIBlwCwlfZsix3VWYMHMsJeFzNIWG3dx 88InP2LEhKgZngCkZt+v7rpj4h2KG9RKMBNCYCqBhqx8KtXJA53cD4wXK4PzQQchYxtHxj EfR5+TmYtJLLiV/8c7EQVvFI0hx+JTcxSxpcbkZoaR3PbWnQycvS/TVtgXYvq1ykjfBzKJ obsg4qKQP51pf7c4mKr+Kw+G6TAht0ArwhRHqmkuscocRMhx1GdBoElihbCEjCKMBTk9QQ nUaXq9IyiVotkL/H6B2/pex/di64z2JPF8FEgo5+wuUFSQGJ73/KXjk4pl4VCw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723606636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TBo6l1L3IPJiesjPRM6MmHqSdZan3zxpLm2Gw9OYx94=; b=Ac4DzGcemlPhQXm7tIKqODXEWB5vslNQiAgXC+rQkrfgfiTAJLzFc8YKniN7voTF7f3J6s blmX/ZUbpOCKhPWOAAGCeYvKX5yjOdUe+B2ErMAqsvK4zpvxGDf7QCjH/QAhdZZ8FfdiVy Cs5HCTOT2PjJCWKgcsPAkR3OAsMzvRHzf40Jl7KWDpYBJ8g2DG+uc8gCFwa6lxf72THeam jVAbyLyq80KwiBKABJFtvWxzpPjjfjDM016anVubGe/wgQRrzJg++9VUgqFgqiqvWeJboU Brj2QidCckbvPsqxBLzHwKbViW8NQwGYX3zU4/pVNV0V955Q33NSt1pbniP0wQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WkDTS3Cf8zdjF; Wed, 14 Aug 2024 03:37:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47E3bGuA069839; Wed, 14 Aug 2024 03:37:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47E3bGlt069836; Wed, 14 Aug 2024 03:37:16 GMT (envelope-from git) Date: Wed, 14 Aug 2024 03:37:16 GMT Message-Id: <202408140337.47E3bGlt069836@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: 7088bf662d46 - releng/13.4 - calendar: don't setlogin(2) in the -a user handlers List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.4 X-Git-Reftype: branch X-Git-Commit: 7088bf662d46ef321a5838d290285086cd6446d2 Auto-Submitted: auto-generated The branch releng/13.4 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=7088bf662d46ef321a5838d290285086cd6446d2 commit 7088bf662d46ef321a5838d290285086cd6446d2 Author: Kyle Evans AuthorDate: 2024-08-05 18:43:56 +0000 Commit: Kyle Evans CommitDate: 2024-08-14 03:36:52 +0000 calendar: don't setlogin(2) in the -a user handlers As of e67975d331 ("Fix 'calendar -a' in several ways."), `calendar -a` will now fork off a new process for each user and do all of its own processing in the user's own context. As a side-effect, calendar(1) started calling setlogin(2) in each of the forked processes and inadvertently hijacked the login name for the session it was running under, which was typically not a fresh session but rather that of whatever cron/periodic run spawned it. Thus, daily and security e-mails started coming from completely arbitrary user. We could create a new session, but it appears that nothing calendar(1) does really needs the login name to be clobbered; opt to just avoid the setlogin(2) call entirely rather than incur the overhead of a new session for each process. PR: 280418 Reviewed by: des, olce Approved by: re (cperciva) Fixes: e67975d331 ("Fix 'calendar -a' in several ways.") (cherry picked from commit 6cb8b61efe8899ee9194563108d0ae90c1eb89e3) (cherry picked from commit 3a9010c98b3d9676307fac20d42cdd3cfd4bc46d) --- usr.bin/calendar/calendar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.bin/calendar/calendar.c b/usr.bin/calendar/calendar.c index 476c0495d218..2e3baee7d57f 100644 --- a/usr.bin/calendar/calendar.c +++ b/usr.bin/calendar/calendar.c @@ -224,7 +224,7 @@ main(int argc, char *argv[]) lc = login_getpwclass(pw); if (setusercontext(lc, pw, pw->pw_uid, - LOGIN_SETALL) != 0) + LOGIN_SETALL & ~LOGIN_SETLOGIN) != 0) errx(1, "setusercontext"); setenv("HOME", pw->pw_dir, 1); cal();