From owner-freebsd-hackers@FreeBSD.ORG Wed Jul 13 21:09:55 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 754FC16A41C for ; Wed, 13 Jul 2005 21:09:55 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from nic.ach.sch.gr (nic.sch.gr [194.63.238.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3F8B43D45 for ; Wed, 13 Jul 2005 21:09:54 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: (qmail 1303 invoked by uid 207); 13 Jul 2005 21:09:48 -0000 Received: from keramida@freebsd.org by nic by uid 201 with qmail-scanner-1.21 (sophie: 3.04/2.19/3.81. Clear:RC:1(81.186.70.54):. Processed in 0.690511 secs); 13 Jul 2005 21:09:48 -0000 Received: from dialup54.ach.sch.gr (HELO gothmog.gr) ([81.186.70.54]) (envelope-sender ) by nic.sch.gr (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 13 Jul 2005 21:09:47 -0000 Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.13.4/8.13.4) with ESMTP id j6DL9gxd000938; Thu, 14 Jul 2005 00:09:42 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from giorgos@localhost) by gothmog.gr (8.13.4/8.13.4/Submit) id j6DL9giJ000937; Thu, 14 Jul 2005 00:09:42 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Thu, 14 Jul 2005 00:09:42 +0300 From: Giorgos Keramidas To: Sam Leffler Message-ID: <20050713210941.GA841@gothmog.gr> References: <42D3E8D9.6020105@xbsd.org> <20050712221444.GA1180@gothmog.gr> <42D56C15.2070400@errno.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42D56C15.2070400@errno.com> Cc: freebsd-hackers@freebsd.org, Florent Thoumie Subject: Re: SIMPLEQ_* macros from OpenBSD sys/queue.h X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2005 21:09:55 -0000 On 2005-07-13 12:31, Sam Leffler wrote: > Giorgos Keramidas wrote: > >OpenBSD tries to keep this header in sync with NetBSD, AFAICT from > >the cvs logs in their tree. > > > >I have the queue.h headers from all three on my disk and I'm already > >looking at the differences, so if you don't mind waiting 1-2 days so > >that I can run any changes through a buildworld I'll give it a try. > > > >If you have changes that depend on SIMPLEQ_* that could serve as a > >test case that you can share, it would be nice too :-) > > trouble% grep STAILQ /sys/dev/ubsec/ubsec.c > #define SIMPLEQ_HEAD STAILQ_HEAD > #define SIMPLEQ_ENTRY STAILQ_ENTRY > #define SIMPLEQ_INIT STAILQ_INIT > #define SIMPLEQ_INSERT_TAIL STAILQ_INSERT_TAIL > #define SIMPLEQ_EMPTY STAILQ_EMPTY > #define SIMPLEQ_FIRST STAILQ_FIRST > #define SIMPLEQ_REMOVE_HEAD STAILQ_REMOVE_HEAD_UNTIL > #define SIMPLEQ_FOREACH STAILQ_FOREACH > > Not sure who's to blaim for this but it'd be nice to unify the names > so drivers don't need portability shims like this. I couldn't agree more. Helping source-level compatibility, as much as this can be accomplished for kernel code, is definitely a plus. This is partly the reason why I noted that OpenBSD synchronized their queue.h header with NetBSD a few times in the past. I just didn't propose something like this because I'm not sure I can convince any of the three BSD teams to s/SIMPLEQ/STAILQ/ or vice versa :-) - Giorgos