From owner-svn-src-all@freebsd.org Thu Aug 13 04:58:49 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6C0499F75E for ; Thu, 13 Aug 2015 04:58:49 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ig0-f179.google.com (mail-ig0-f179.google.com [209.85.213.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BB0E800 for ; Thu, 13 Aug 2015 04:58:49 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: by igbjg10 with SMTP id jg10so56674342igb.0 for ; Wed, 12 Aug 2015 21:58:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=gngmxJkaaaFPSxIKMp2TxxVHLibQtXUbGTFvG4Thark=; b=KlzBuYCFUm71SXr5/LehBIGqeqkeL0DZP9LbdfANiFpN5Z7kCra6882dTAoUcg640Y gnczPZTAXsMGhJd6QQvqdJwXubCYDv3vLlOHwm9y5Db9iKk1Z5EQ+4Ud9Ry71LYYOnD7 yS1L7ozr7porhlTn5h2UkYGKYT/tvcPrQnsX5ElR4P1Bldm55NlZ8TYcc55A+1vgmmec QfnM87vFMkrVXQqU8g5epyLt9TrLARZpwFeWs+75czm9pvR9KF5MRSC5etY1Fwk7REM9 5g/FUEBTF5imbFSByX5iK81bWt582ar0P0sFYpWR+7R5WirHxQGtEOuItsGMyBM4phnx H5dA== X-Gm-Message-State: ALoCoQm8PTIiZRIW4uiRcBeQxQxZsnfKs8slb6+XPACMIfwH4eYYOflUt0ZLlBIX1WF8BArUZWef X-Received: by 10.50.61.243 with SMTP id t19mr16034545igr.24.1439441923601; Wed, 12 Aug 2015 21:58:43 -0700 (PDT) Received: from netflix-mac.bsdimp.com ([50.253.99.174]) by smtp.gmail.com with ESMTPSA id cr1sm798618igb.15.2015.08.12.21.58.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Aug 2015 21:58:43 -0700 (PDT) Sender: Warner Losh Subject: Re: svn commit: r286687 - head Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Content-Type: multipart/signed; boundary="Apple-Mail=_3A5AEC53-14D0-48CB-B145-E4826EBCD00C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Warner Losh In-Reply-To: <7AE78D6D-DE39-4C0F-A2AC-4778F4E304A8@gmail.com> Date: Wed, 12 Aug 2015 22:58:47 -0600 Cc: Julian Elischer , Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201508121900.t7CJ0mhT080491@repo.freebsd.org> <55CC2114.4080904@freebsd.org> <7AE78D6D-DE39-4C0F-A2AC-4778F4E304A8@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2015 04:58:49 -0000 --Apple-Mail=_3A5AEC53-14D0-48CB-B145-E4826EBCD00C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Aug 12, 2015, at 10:52 PM, Garrett Cooper = wrote: >=20 > On Aug 12, 2015, at 21:46, Julian Elischer wrote: >=20 >> On 8/13/15 3:00 AM, Warner Losh wrote: >>> Author: imp >>> Date: Wed Aug 12 19:00:47 2015 >>> New Revision: 286687 >>> URL: https://svnweb.freebsd.org/changeset/base/286687 >>>=20 >>> Log: >>> Document build-tools better. Add rescue back because it builds = /bin/sh >>> which has a build-tools target (see commit for how build-tools and >>> cross-tools differ). >> really? do we build ALL of rescue? that contains most of /bin and = lots of /usr/bin. >=20 > build-tools only builds /bin/sh and bin/tcsh : >=20 > $ grep BUILDTOOLS rescue/rescue/Makefile > CRUNCH_BUILDTOOLS+=3D bin/sh > CRUNCH_BUILDTOOLS+=3D bin/csh >=20 >> that's a lot.. Can we not just build/bin/sh itself? >=20 > That would.. probably make more sense (especially in a = post-projects/bmake world)=85 but it needs better comments in = Makefile.inc1 . Actually, what we have is totally fine. There=92s nothing to see here. = This is now commented adequately in Makefile.inc1, and listing things in = Makefile.inc1 is totally wrong other than rescue/rescue because rescue builds things with = a different MAKEOBJDIRPREFIX. Rather than have a plethora of =91reach = overs=92 to get the built build-tools, and create the crazy build dependencies, = we waste < 2s of your time. If somebody wants to convert rescue.mk and bsd.crunchgen.mk to something more meta-mode friendly, that might be interesting, but it=92s = independent of Makefile.inc1 (mostly because that=92s unused in Meta mode). Warner --Apple-Mail=_3A5AEC53-14D0-48CB-B145-E4826EBCD00C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVzCQHAAoJEGwc0Sh9sBEApMoQAK3X49rd6NO2tiwDCrLlWkS6 XpEIRo9Z9ng89LMYPEM4marweTc+z+CFpiBjMREbUtLfFUHI83THaCnfou7eAhff L9u8rw9IxtiZNcIgD70MuIWEsPLRmq6OD5io7a4GHyZqh5g4LA0gv78ihkpUtDfJ YNDKQmqHoDE9rm/a+p6wI5R7lVvWi5kpO7IJQWY6LJ43UcTdSJVFBYSIOaHMneH3 x9FydYfCMB9WY02ZdBmoql3ZcJ2Pw0NeTfY2/9jLqRCOo7H3iEMVCGFjvpBDYGGg BOqQ/2+ud5pH3mgW5/zlu96k0Va6lBuaFI5reBF6/xG17+o7qt3UQ9e9sotPl/Yj uTdoBuRKfQGItdRG62IY9GnrbQKaxIOeMPAdEaffKSK/15XhiR7MS5KDnaxrDJx+ GTRQGZBjnPYYkejnS97Hnj3jc8SQXX4GGfo0BhFUf52iI+AdRKaBRKPP0mJrEFmy UGzN9W1smzT4LwEP2A1Jp2mvk40KM63FiN90I9EouohW/WxONxAR+AUgoZvdFscB niN5oJyrSI0SPaPM8QfYw44+G45fvIZFcPLquFxs253LxzLd5aEpUILQQxp7vvVa 1fg+dUONdbJtlZqJYVIgCShHRy4maQ+vAqALGaJwnwRMVDxVzUU4cpa6Omg7sW4D i1GIh0NkUjEtLin6HdiX =BTXH -----END PGP SIGNATURE----- --Apple-Mail=_3A5AEC53-14D0-48CB-B145-E4826EBCD00C--