From owner-svn-src-head@freebsd.org  Fri Jan 22 18:04:13 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90AA7A8C6CA;
 Fri, 22 Jan 2016 18:04:13 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7B4651736;
 Fri, 22 Jan 2016 18:04:12 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u0MI4BAQ001262
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 22 Jan 2016 10:04:11 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u0MI4BlO001261;
 Fri, 22 Jan 2016 10:04:11 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 22 Jan 2016 10:04:11 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Lawrence Stewart <lstewart@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r294536 - head/sys/netinet
Message-ID: <20160122180411.GA1004@FreeBSD.org>
References: <201601212253.u0LMrC7B016136@repo.freebsd.org>
 <56A1C9F6.2010708@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56A1C9F6.2010708@freebsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jan 2016 18:04:13 -0000

On Fri, Jan 22, 2016 at 05:19:34PM +1100, Lawrence Stewart wrote:
L> On 01/22/16 09:53, Gleb Smirnoff wrote:
L> > Author: glebius
L> > Date: Thu Jan 21 22:53:12 2016
L> > New Revision: 294536
L> > URL: https://svnweb.freebsd.org/changeset/base/294536
L> > 
L> > Log:
L> >   Refactor TCP_CONGESTION setsockopt handling:
L> >   - Use M_TEMP instead of stack variable.
L> >   - Unroll error handling, removing several levels of indentation.
L> 
L> As noted privately elsewhere, this change introduces races with respect
L> to CC algorithm module unloading which will need to be fixed. Just
L> mentioning it again publicly so others are aware of it.

In the code checked in the check for (CC_ALGO(tp)->ctl_output being
not NULL and the actual call are under the same lock.

Is that the race you refer to?

-- 
Totus tuus, Glebius.