From owner-svn-src-head@FreeBSD.ORG Fri Jan 23 21:49:07 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ACAB82E8; Fri, 23 Jan 2015 21:49:07 +0000 (UTC) Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com [IPv6:2a00:1450:400c:c00::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E9158D0; Fri, 23 Jan 2015 21:49:07 +0000 (UTC) Received: by mail-wg0-f47.google.com with SMTP id n12so9826353wgh.6; Fri, 23 Jan 2015 13:49:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=8uxXlsVFcubfqVG2HelUTxmqDMmS/tELOOMkfCP8v+0=; b=CBV/1EPuALh292SaFwprOajAuY3IqP6IN2ckwarOdMQJaojVJeu5rnh0h8iRHpmvUO IqkugO8r0jLkxezsygXgerHGp3wteR5gsIuuMw+TemgrOUeMec7HpU2VywXLst3WXesM Af8Xs+KTkzjFp4QOtVRdYbaZplx5gRg2B/hR+VGn8eoRGB0ipkpuloMNTSJos9tPrQnZ Z8YdQzgD44H01nwWrzs+QVjxr1c6cCGR3+iF/Hn4VnA9/6+m3IAFJ2MAt56SDWYMKmel tsICB3KRPXUAqFxh//Evlq5nk6ChsQ0pPsmy7fy6IgjnX9FgHNJVypz/bO+SjhqCNnrI zJAQ== MIME-Version: 1.0 X-Received: by 10.180.211.176 with SMTP id nd16mr7690935wic.23.1422049745804; Fri, 23 Jan 2015 13:49:05 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.17.129 with HTTP; Fri, 23 Jan 2015 13:49:05 -0800 (PST) In-Reply-To: References: <201501231618.t0NGIeDv057991@svn.freebsd.org> <20150123205617.GB56104@sol.firepipe.net> Date: Fri, 23 Jan 2015 14:49:05 -0700 X-Google-Sender-Auth: 9JScbwcbmzkiNI2PEEHN_E0e5ZE Message-ID: Subject: Re: svn commit: r277570 - head/usr.bin/vmstat From: Alan Somers To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Will Andrews X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:49:07 -0000 On Fri, Jan 23, 2015 at 2:18 PM, Davide Italiano wrote: > On Fri, Jan 23, 2015 at 12:56 PM, Will Andrews wrote: >> On Fri, Jan 23, 2015 at 11:23:57AM -0800, Davide Italiano wrote: >>> What's the rationale behind this change? >> >> The rationale was to match the clock used to the name (and implied intent) >> of the variables used to store/manipulate the data. >> >> It's possible that 'uptime' is entirely the wrong term in vmstat, in which >> case the naming used elsewhere in vmstat needs to be changed too. >> >> -- >> wca > > I don't think this is a reason strong enough, we should rather go the > other way around as already suggested. > I would like to see this reverted. > > Thanks, > > -- > Davide > I agree with Ian that vmstat ought to be using a monotonic clock, and that the ideal change would be to rename all of its "uptime" variables accordingly. But reverting this change would be the worst possible outcome because we'd be back in the original situation of wrong variable names that are wrongly set. As is, the change has no functional effect because CLOCK_MONOTONIC and CLOCK_UPTIME are identical (see kern_clock_gettime). -Alan