From owner-cvs-src@FreeBSD.ORG Mon Mar 10 18:11:09 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D13051065679; Mon, 10 Mar 2008 18:11:09 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 87AF58FC3F; Mon, 10 Mar 2008 18:11:09 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 270DF46B33; Mon, 10 Mar 2008 14:11:08 -0400 (EDT) Date: Mon, 10 Mar 2008 18:11:08 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John Baldwin In-Reply-To: <200803101348.47724.jhb@freebsd.org> Message-ID: <20080310180939.V70549@fledge.watson.org> References: <200803091349.m29Dn91v003746@repoman.freebsd.org> <200803101244.52073.jhb@freebsd.org> <20080310171551.Y70549@fledge.watson.org> <200803101348.47724.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/gzip gzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2008 18:11:10 -0000 On Mon, 10 Mar 2008, John Baldwin wrote: >>> So are we creating packages for ports that are compressed with gzip but >>> using bzip names? Otherwise, gunzip should probably fail on a '.tbz' >>> because it isn't a gzipped file (unless gunzip auto-invokes bunzip2 or >>> some such feature that I'm not aware of). >> >> gunzip is smarter than you think. :-) > > Hmm. I guess I would consider it a user error to use gunzip on a bzip'd > file (round peg, square hole sort of deal). However, that has more to do > with the functionality (which I find surprising and perhaps a bit > non-UNIX-ish) rather than this specific patch. Yeah -- this change was really just about teaching gunzip that unzipping a .tbz or .tbz2 file is like unzipping a .tgz or .tgz2 file as was the case for .tgz: rename it to .tar when it's unzipped. The functionality to unzip bz2 files was already present, you just end up with a different file extension when done. I can see arguments for and against that, but nothing to do with the patch I committed. :-) Robert N M Watson Computer Laboratory University of Cambridge