From owner-freebsd-hackers Mon Jan 29 16:55: 6 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id DCAA537B400 for ; Mon, 29 Jan 2001 16:54:48 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0U0nZ351359; Mon, 29 Jan 2001 16:49:35 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200101292345.f0TNj6A79322@earth.backplane.com> Date: Mon, 29 Jan 2001 16:54:34 -0800 (PST) From: John Baldwin To: Matt Dillon Subject: Re: Suboptimal mmap of devices on i86 Cc: freebsd-hackers@FreeBSD.org, Drew Eckhardt Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 29-Jan-01 Matt Dillon wrote: > I like it, with some minor tweaks. I recommend: > > * name the new function vm_map_findspace2() (or something similarly > short. > > * change all callers of vm_map_findspace() to instead call > vm_map_findspace2() directly. > > * depreciate the original vm_map_findspace() entirely (get rid of > it rather then supplying a compatibility function). > > The name change is to ensure that out of date loadable modules > don't try to use the new function with the wrong arguments. Better > to get a kld error then to crash. > > -Matt Oh yuck. Please do rename the darn thing back at some point then. Or if its only going to be in -current, don't bother. No one expects to be able to use a 4.x module in 5.x, so just change the function w/o the old name. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message