From owner-svn-ports-head@freebsd.org Fri Feb 12 19:09:01 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9E60AA7E91; Fri, 12 Feb 2016 19:09:01 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 302FA1F90; Fri, 12 Feb 2016 19:09:00 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 1474514d TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Fri, 12 Feb 2016 12:08:57 -0700 (MST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: svn commit: r408737 - head/ports-mgmt/portmaster From: Adam Weinberger In-Reply-To: Date: Fri, 12 Feb 2016 12:08:55 -0700 Cc: Mathieu Arnold , "ports-committers@freebsd.org" , "svn-ports-all@freebsd.org" , "svn-ports-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <01DE2FBD-BE93-4100-BB6A-72898EAE6F46@adamw.org> References: <201602121546.u1CFk4fB037748@repo.freebsd.org> To: Jason Helfman X-Mailer: Apple Mail (2.3112) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 19:09:01 -0000 > On 12 Feb, 2016, at 11:01, Jason Helfman wrote: >=20 > On Fri, Feb 12, 2016 at 7:46 AM, Mathieu Arnold = wrote: >> Author: mat >> Date: Fri Feb 12 15:46:04 2016 >> New Revision: 408737 >> URL: https://svnweb.freebsd.org/changeset/ports/408737 >>=20 >> Log: >> Remove unneeded dependencies on bash and zsh. >>=20 >> With hat: portmgr >> Sponsored by: Absolight >>=20 >> Modified: >> head/ports-mgmt/portmaster/Makefile >>=20 >> Modified: head/ports-mgmt/portmaster/Makefile >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:34:10 2016 = (r408736) >> +++ head/ports-mgmt/portmaster/Makefile Fri Feb 12 15:46:04 2016 = (r408737) >> @@ -2,6 +2,7 @@ >>=20 >> PORTNAME=3D portmaster >> PORTVERSION=3D 3.17.9 >> +PORTREVISION=3D 1 >> CATEGORIES=3D ports-mgmt >> MASTER_SITES=3D LOCAL/bdrewery/${PORTNAME}/ \ >> http://mirror.shatow.net/freebsd/${PORTNAME}/ \ >> @@ -24,9 +25,6 @@ PLIST_FILES=3D sbin/portmaster \ >> BASH_PLIST_FILES=3D etc/bash_completion.d/portmaster.sh >> ZSH_PLIST_FILES=3D share/zsh/site-functions/_portmaster >>=20 >> -BASH_RUN_DEPENDS=3D bash>=3D0:${PORTSDIR}/shells/bash >> -ZSH_RUN_DEPENDS=3D zsh>=3D0:${PORTSDIR}/shells/zsh >> - >> verify: checksum >>=20 >=20 > Does this break run dependency if a user chooses option of bash/zsh, > as helper files will be installed, but > bash/zsh won't be installed? Yes, it does. But it's better without the dependencies. The actual program itself works perfectly without bash or zsh. But then = you install zsh one day and *poof* you get completions. Removing zsh = shouldn't deinstall portmaster, upgrading zsh shouldn't reinstall = portmaster, and errors in the zsh port shouldn't prevent portmaster = packages from being produced. The bigger problem is that the completions aren't enabled by default. = Ports should do what pkg does: install completions as part of the = default package. My car is capable of pairing with Android phones and iPhones, but that = doesn't mean it needs to include an Android phone and an iPhone when you = buy the car. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org