Date: Tue, 08 Sep 2009 11:33:48 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: ports@freebsd.org Subject: {incorrect,unsafe} use of UNZIP_CMD Message-ID: <864ordn5kz.fsf@ds4.des.no>
next in thread | raw e-mail | index | archive | help
des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs grep = 'DEPEND.*UNZIP' /dev/null ./audio/libamrnb/Makefile:BUILD_DEPENDS=3D ${UNZIP_CMD}:${PORTSDIR}/= archivers/unzip ./audio/libamrwb/Makefile:BUILD_DEPENDS=3D ${UNZIP_CMD}:${PORTSDIR}/= archivers/unzip ./databases/pgtcl/Makefile:BUILD_DEPENDS=3D ${UNZIP_CMD}:${PORTSDIR}/= archivers/unzip ./emulators/xgs/Makefile:EXTRACT_DEPENDS=3D ${UNZIP_CMD}:${PORTSDIR}/= archivers/unzip ./games/pykawari/Makefile:EXTRACT_DEPENDS=3D${UNZIP_CMD}:${PORTSDIR}/archiv= ers/unzip ./lang/f2c/Makefile:EXTRACT_DEPENDS=3D${UNZIP_CMD}:${PORTSDIR}/archivers/un= zip This will fail if the user redefines UNZIP_CMD to e.g. "unzip -v". all of these should just set USE_ZIP: des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs egrep= 'EXTRACT_DEPENDS.*(UNZIP|unzip)' /dev/null ./cad/leocad/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzip ./deskutils/superkaramba-lwp/Makefile:EXTRACT_DEPENDS=3D unzip:${PORTSDIR}= /archivers/unzip ./devel/tavrasm/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzip ./emulators/xgs/Makefile:EXTRACT_DEPENDS=3D ${UNZIP_CMD}:${PORTSDIR}/= archivers/unzip ./emulators/m2000/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/un= zip ./emulators/vmsbackup/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archiver= s/unzip ./games/cgoban2/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzip ./games/openarena/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/un= zip ./games/pykawari/Makefile:EXTRACT_DEPENDS=3D${UNZIP_CMD}:${PORTSDIR}/archiv= ers/unzip ./games/sdb/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archivers/unzip ./games/ezquake/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzi= p \ ./games/ufoai-data/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/u= nzip ./games/quake-data/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./games/quake-extras/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./games/tremor/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unzip ./games/doomlegacy/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/u= nzip ./games/uhexen/Makefile:EXTRACT_DEPENDS=3D unzip:${PORTSDIR}/archive= rs/unzip ./games/kmquake2/Makefile:EXTRACT_DEPENDS=3Dunzip:${PORTSDIR}/archivers/unz= ip ./games/galaxyhack/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./hungarian/hunspell/Makefile:#EXTRACT_DEPENDS=3D unzip:${PORTSDIR}/archive= rs/unzip ./japanese/edict-utf-8/Makefile:EXTRACT_DEPENDS=3D unzip:${PORTSDIR}= /archivers/unzip ./japanese/tomoe/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./java/diablo-jdk15/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./java/diablo-jdk16/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./java/diablo-jre15/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./java/diablo-jre16/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./java/sun-wtk/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./lang/f2c/Makefile:EXTRACT_DEPENDS=3D${UNZIP_CMD}:${PORTSDIR}/archivers/un= zip ./sysutils/memtest86/Makefile:EXTRACT_DEPENDS=3D unzip:${PORTSDIR}/archive= rs/unzip ./textproc/fop/Makefile:EXTRACT_DEPENDS+=3D unzip:${PORTSDIR}/archive= rs/unzip ./www/mambo/Makefile:EXTRACT_DEPENDS=3D unzip:${PORTSDIR}/archivers/unzip So should these: des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs egrep= 'EXTRACT_CMD.*(UNZIP|unzip)' /dev/null ./deskutils/superkaramba-lwp/Makefile:EXTRACT_CMD=3D ${UNZIP_C= MD} ./games/pykawari/Makefile:EXTRACT_CMD=3D ${UNZIP_CMD} ./misc/projectionlib/Makefile:EXTRACT_CMD=3D unzip -a java/jdk14 is just... weird. I won't paste the Makefile here. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?864ordn5kz.fsf>