From nobody Mon Apr 17 13:13:57 2023
X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q0SDj3QmHz45stF;
Mon, 17 Apr 2023 13:13:57 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
client-signature RSA-PSS (4096 bits) client-digest SHA256)
(Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0SDj31rQz3t7R;
Mon, 17 Apr 2023 13:13:57 +0000 (UTC)
(envelope-from git@FreeBSD.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
t=1681737237;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=oEnwOjn3Nov2ZiWjfRWzkcYGQqGvKDfXG4G7MgMfKmI=;
b=sOCwhVpvS227MBzJW5dyXPu9H7JfnxNpaUwybnkZQitTGaJjQxB7oLH2zQA4gOavWkxQYK
YEnQRCFK5dFcRzCEW1xzbu55v6HEv+hseXri+066I3A93aOhsDqsYhgDz434pDZC7FbIXc
ShoDHAiaCV2YRnfSlI61SdM1HUa10Aj1y/4+oQ2wD2KPIYmT+/0LKtrnTfyCWxtFZtxTiV
QZ3j9PtE5r7fXNRd0mzQLNmwvirfsJg1NC5BzSh8nuL3/ABC198LjngQItEGqe0jXwfxDd
s8LS4RxtfpniG1LZn5Yim+FPURAk2/Ict2LMoDZL+xnuuNsvsA1irwdqPVzhKA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
s=dkim; t=1681737237;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=oEnwOjn3Nov2ZiWjfRWzkcYGQqGvKDfXG4G7MgMfKmI=;
b=Qf29QKUKSKNuJYequvDR0Q1xX29VqHfTKLgk1HexAlLJCcqHtHZkPBx61zmedRNgJBSo8d
G7oPldZWn96Fh5oFHeuTz19blrge5iprD9TdjlHNnKKpfT8/qtbPFl9IsEWvGDb9tlyhGV
6yMrYwYiu0eYYZ+3rWME5T1O6g4Cal2wJQY53k3zrWVE0honWNgjmED99J4UE1sRExIzxc
e79x834k+s9nuYqa6oM50oW1WTzTDzbA3TSBpxoR7HVmAwqQ3IH+ltQkLexWoB57A1kilY
o+PWsv2pW7D0dcj7dkg6OtHwUVPaII61Kh4qASCjQsC0spCaiyJJ7olUb/K2fA==
ARC-Authentication-Results: i=1;
mx1.freebsd.org;
none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681737237; a=rsa-sha256; cv=none;
b=YqsUsJHr+EbjCOBRkbds38TT1XCr3TGPmX2NshFXayymwSIS5XidkBiF1Av7g3HEsaHrO2
DwjVOYNqA8u5EASACW65tPUOJJUs7h/aiyXSGhMkGXm2ipCchAvBBWQDdyEDtAbt94tnbg
lBUQ9sXIHUFHjAjAdAN8odQuQbhBTxvBJiQgGioj6EETb209KMW94gUFLVRGNCTx0n1urU
GCbSed3zcssZhoef0OaL1lCXBOqnImh//+/hm2Z2cr4c052CQYR5S/2MaVOqKz/zHHrk8S
DdRMg2PzTe7lwR6glrvRAuuMOuMB9uXsE+XKlamU4h3N+KerYn7KRWbKcS6ZVA==
Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
(Client did not present a certificate)
by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q0SDj27KbzWNw;
Mon, 17 Apr 2023 13:13:57 +0000 (UTC)
(envelope-from git@FreeBSD.org)
Received: from gitrepo.freebsd.org ([127.0.1.44])
by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33HDDvSR023520;
Mon, 17 Apr 2023 13:13:57 GMT
(envelope-from git@gitrepo.freebsd.org)
Received: (from git@localhost)
by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33HDDvoj023519;
Mon, 17 Apr 2023 13:13:57 GMT
(envelope-from git)
Date: Mon, 17 Apr 2023 13:13:57 GMT
Message-Id: <202304171313.33HDDvoj023519@gitrepo.freebsd.org>
To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
dev-commits-src-branches@FreeBSD.org
From: Ed Maste <emaste@FreeBSD.org>
Subject: git: 40399b2a4a8a - stable/12 - awk: errror on printf format strings lacking conversion specifier
List-Id: Commits to the stable branches of the FreeBSD src repository <dev-commits-src-branches.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches
List-Help: <mailto:dev-commits-src-branches+help@freebsd.org>
List-Post: <mailto:dev-commits-src-branches@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-branches+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-branches+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-branches@freebsd.org
X-BeenThere: dev-commits-src-branches@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Git-Committer: emaste
X-Git-Repository: src
X-Git-Refname: refs/heads/stable/12
X-Git-Reftype: branch
X-Git-Commit: 40399b2a4a8a1a2bceb7ab484b53aa20f7189ed9
Auto-Submitted: auto-generated
X-ThisMailContainsUnwantedMimeParts: N
The branch stable/12 has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=40399b2a4a8a1a2bceb7ab484b53aa20f7189ed9
commit 40399b2a4a8a1a2bceb7ab484b53aa20f7189ed9
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-04-14 14:49:05 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-04-17 13:13:45 +0000
awk: errror on printf format strings lacking conversion specifier
Reported by: phk
Reviewed by: imp, markj
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D39573
(cherry picked from commit 5dbd073b045c8e98730c025a4acf2279be26c33e)
(cherry picked from commit 46529cb990402ed46f5f3555aecc41091ef63f41)
---
contrib/one-true-awk/run.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/one-true-awk/run.c b/contrib/one-true-awk/run.c
index 117fb0748bd8..b81dafba35e6 100644
--- a/contrib/one-true-awk/run.c
+++ b/contrib/one-true-awk/run.c
@@ -912,6 +912,9 @@ int format(char **pbuf, int *pbufsize, const char *s, Node *a) /* printf-like co
case 'c':
flag = 'c';
break;
+ case '\0':
+ FATAL("missing printf conversion specifier");
+ break;
default:
WARNING("weird printf conversion %s", fmt);
flag = '?';