From owner-p4-projects@FreeBSD.ORG  Thu Aug 30 18:34:59 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5DAA716A418; Thu, 30 Aug 2007 18:34:59 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 006B816A468
	for <perforce@FreeBSD.org>; Thu, 30 Aug 2007 18:34:59 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id D442B13C48A
	for <perforce@FreeBSD.org>; Thu, 30 Aug 2007 18:34:58 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7UIYwpg079361
	for <perforce@FreeBSD.org>; Thu, 30 Aug 2007 18:34:58 GMT
	(envelope-from cnst@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7UIYw8e079358
	for perforce@freebsd.org; Thu, 30 Aug 2007 18:34:58 GMT
	(envelope-from cnst@FreeBSD.org)
Date: Thu, 30 Aug 2007 18:34:58 GMT
Message-Id: <200708301834.l7UIYw8e079358@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	cnst@FreeBSD.org using -f
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 125866 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Aug 2007 18:34:59 -0000

http://perforce.freebsd.org/chv.cgi?CH=125866

Change 125866 by cnst@dale on 2007/08/30 18:34:27

	there appears to be a bug in the compiler that only seems to compile
	this usage of the e notation on i386, but not on amd64.
	
	amd64 users would get an "SSE register return with SSE disabled" gcc 4.2.1 error;
	however, on i386 neither gcc 4.2.0 nor gcc 4.2.1 would return even the slightest sign
	of a warning message regarding the line.
	
	Discussed on freebsd-current@ and a few irc/silc channels a few days ago.
	
	See http://lists.freebsd.org/pipermail/freebsd-current/2007-August/076431.html
	
	Some comments from imp@ and des@.
	
	P.S. Yes, I probably should not have used the e notation in the first place,
	however, after doing some tests I originally concluded that it didn't make a
	difference in the code that's generated, but it does improve readability --
	hence the e notation was used. :-)
	
	Compile tested on amd64 by:	h.schmalzbauer@omnisec.de
					syrinx@
	
	Tested on i386 with Core 2 by:	cnst@

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#6 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.coretemp/coretemp.c#6 (text+ko) ====

@@ -294,6 +294,6 @@
 		s->value = 0;
 	} else {
 		s->flags &= ~SENSOR_FINVALID;
-		s->value = temp * 1e6 + 273.15e6;
+		s->value = temp * 1000000 + 273150000;
 	}
 }