From nobody Fri Aug 1 09:40:33 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4btgtM4vDBz63hfj; Fri, 01 Aug 2025 09:40:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4btgtL5mWgz448c; Fri, 01 Aug 2025 09:40:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=MtNTDVUr; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::733 as permitted sender) smtp.mailfrom=markjdb@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) Received: by mail-qk1-x733.google.com with SMTP id af79cd13be357-7e344e0212eso174787885a.0; Fri, 01 Aug 2025 02:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754041237; x=1754646037; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=KQ844/YbFP6FKcxD9f12hrFenOMkY+6Q2Gt4b77uLzk=; b=MtNTDVUru4kIPEJTaYUOXmygE49C5Nf3yHKf5Pk+iQRH4pT5hGHFN1SUzvB1T25XQj 7erQxoT8ttponqB4cl9l5xZaDlqRH0qfd/CdRLFq0ZIiOppyEWOHs36QfcCvHJso0bP9 poPagLNhE7gc6WGljZJ8dHfyT4n3F8a4Dkh9I1HfYEIPWsIaQ9W10OZUd9dFEzvqWWbk BRkSQFVU1q+3jcJ2G37k7EZ5FE86ISUBn5E5pnX65o2LK140hdh43aRIK+uLAm5ORE2R p2jv0bXldmdLkzTkkOwcvHk4986y0cKcZJgU/syCPel6Ib/gnuWGHRHTMaNM4tUjPA7H l+Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754041237; x=1754646037; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KQ844/YbFP6FKcxD9f12hrFenOMkY+6Q2Gt4b77uLzk=; b=tI+41rhIgserePOH4mXbfdp+wx+bfbrHqM9JmCx8dUDHmmjqM3a+iJUrMBVShpmJrh cnHV8gOzGCS6rqwrg/C7LLFsBiE4c4ox2HMmOgFjwRyeA2SV5JQmsZHEuiNGriiWO7fK 3sQaYr1jP4b7MvdxGY2+3hDp+iGWdiw92CDgMR9Q9auY1NCt8m1nqr322XgvuFzkTRNA g+CFAUtyh2adE/qNM1ZwY7c2sv0qZ8Jv7Hcv+tsj7HnjE6bx7+ykqKDM3lkf3DzBwl1t DZlP2CBzuhYk9HSGoF6F90pBN4T6BhcCZwRsuFsMZmGk2WUQ+UHTKw2HFQWtPl0V9nc9 LQXw== X-Forwarded-Encrypted: i=1; AJvYcCUxn2NGNepFoxqBsdcdZfBmN/xNbR34Lrr+YnTwWvosVgZ69mBFIGEMTGG1RiFpVmQzlJnjccPGiUQ865/ihsgBtiYKeHw=@freebsd.org, AJvYcCW1RUx2q2Ko6gHno7hf2yW0YU9AvhvIhF91bPzEDFcZbjeEoY29EvyfHarLSC9A3RvmRtyhtyMOQz/wYK5FQIkHAbiT@freebsd.org, AJvYcCXNXN2Dt/Y6ZNz08yt9/Sly9w3UVIqmDmmE+W2ErjIONfE+M2pnyko+Zm2EegPeRr1LIyHFA+Nv5SET+uMU3UU=@freebsd.org X-Gm-Message-State: AOJu0YxAr+623TKwMpdbWD2u3S/I6F+0vq+h5FJDJtZhQRahfDrH+cJI i/LkC7TTesJfw30PaU8Djxssh7eD34mluSQ+Fg803TgloPYle7eIgMM/pZseHIoA X-Gm-Gg: ASbGncvPc+ROIHrEzUPZumq942vK0L3VzfsK/U/Nr5wQXWR22HCYgEpsbvfv1j0wdCT SkDX/73s7lJ2ehDlLuixZvzPUyvo3IkejjA7sUMV5dxu9f9TPM2aN8L5uYx6UgRnL7kUw+JZpei pzItY3D35lmRkCZnLcRpR31UvVNo5Q8+52YSdHjJ+ZZ6ORuAjFLPm8/npClqmCMHFPrwDym3+1e UvgXnBmIkm+Rr1STJxgv+AYwlcd8gFW04R1IPUKNbJ0Gh0Mr8oKbHAEV+alwxWEasxqgVRjPdPI 1VrSM+4IqfdF6ItrfB9MX06pnP6apE9DXdRax9yeF99AVrtjfLlxMyYCHhcV1lyVY1sm5xf3IXA WXABV5WadmWfggRQalLp2nU4xIF+Xg9k/ijMCJ9lNa6C3WY0= X-Google-Smtp-Source: AGHT+IH3NAkEyNvfh5YStforzop0GBnlWJUHFMGm5/TirjUmmEH+KEPC9hENiataM+VGzBukD7fLFA== X-Received: by 2002:a05:620a:1a8c:b0:7ce:eb71:f500 with SMTP id af79cd13be357-7e681435151mr727431485a.28.1754041236442; Fri, 01 Aug 2025 02:40:36 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f5b528bsm197659085a.21.2025.08.01.02.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 02:40:36 -0700 (PDT) Date: Fri, 1 Aug 2025 05:40:33 -0400 From: Mark Johnston To: Kristof Provost Cc: Hareshx Sankar Raj , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ded037e65e52 - main - qat: driver updates to improve code and fix bugs Message-ID: References: <202506061357.556Dv9Zc084087@gitrepo.freebsd.org> <9DB885DF-8BDD-451F-B928-0C10E881C4CF@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9DB885DF-8BDD-451F-B928-0C10E881C4CF@FreeBSD.org> X-Spamd-Result: default: False [-2.58 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.981]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::733:from]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4btgtL5mWgz448c X-Spamd-Bar: -- On Wed, Jul 30, 2025 at 02:29:37PM +0200, Kristof Provost wrote: > On 6 Jun 2025, at 15:57, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=ded037e65e5239671b1292ec987a2e0894b217b5 > > > > commit ded037e65e5239671b1292ec987a2e0894b217b5 > > Author: Hareshx Sankar Raj > > AuthorDate: 2025-05-07 09:38:21 +0000 > > Commit: Mark Johnston > > CommitDate: 2025-06-06 13:43:54 +0000 > > > > qat: driver updates to improve code and fix bugs > > > > Bug fixes and improvements are done for the qat code base > > to improve code quality. > > > > Reviewed by: markj, ziaee > > MFC after: 2 weeks > > Sponsored by: Intel Corporation > > Differential Revision: https://reviews.freebsd.org/D50379 > > --- > … > > diff --git a/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h > > b/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h > > index bfc5db1f5e5c..cddfc3f84853 100644 > > --- a/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h > > +++ b/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h > > @@ -1,11 +1,11 @@ > > /* SPDX-License-Identifier: BSD-3-Clause */ > > -/* Copyright(c) 2007-2022 Intel Corporation */ > > +/* Copyright(c) 2007-2025 Intel Corporation */ > > #ifndef ADF_C3XXX_HW_DATA_H_ > > #define ADF_C3XXX_HW_DATA_H_ > > > > /* PCIe configuration space */ > > -#define ADF_C3XXX_PMISC_BAR 0 > > -#define ADF_C3XXX_ETR_BAR 1 > > +#define ADF_C3XXX_PMISC_BAR 1 > > +#define ADF_C3XXX_ETR_BAR 2 > > #define ADF_C3XXX_RX_RINGS_OFFSET 8 > > #define ADF_C3XXX_TX_RINGS_MASK 0xFF > > #define ADF_C3XXX_MAX_ACCELERATORS 3 > > We’re seeing panics loading the QAT driver on Atom Processor C3000 (with > pfSense). > > I believe this change is the trigger. > This causes us to look for the ETR registers in the third BAR, but there are > only two on that hardware: > > # pciconf -l -b -vV pci0:1:0:0 > none0@pci0:1:0:0: class=0x0b4000 rev=0x11 hdr=0x00 vendor=0x8086 > device=0x19e2 subvendor=0x8086 subdevice=0x19e2 > vendor = 'Intel Corporation' > device = 'Atom Processor C3000 Series QuickAssist Technology' > class = processor > bar [18] = type Memory, range 64, base 0x80700000, size 262144, > enabled > bar [20] = type Memory, range 64, base 0x80740000, size 262144, > enabled Indeed, that portion of the change doesn't make a lot of sense. I posted a patch to revert it and will commit it soon if I don't hear back: https://reviews.freebsd.org/D51664