From owner-cvs-all@FreeBSD.ORG Fri Mar 2 20:03:22 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 679D016A401; Fri, 2 Mar 2007 20:03:22 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 10DE413C48D; Fri, 2 Mar 2007 20:03:21 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l22K3I9g079673; Fri, 2 Mar 2007 15:03:20 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Fri, 2 Mar 2007 15:02:22 -0500 User-Agent: KMail/1.9.1 References: <200703021701.l22H1k3M071057@repoman.freebsd.org> <200703021233.28346.jhb@freebsd.org> <45E870B9.4040403@samsco.org> In-Reply-To: <45E870B9.4040403@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703021502.23689.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 02 Mar 2007 15:03:20 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2702/Fri Mar 2 10:04:51 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Kris Kennaway Subject: Re: cvs commit: src/sys/kern kern_intr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2007 20:03:22 -0000 On Friday 02 March 2007 13:45, Scott Long wrote: > John Baldwin wrote: > > On Friday 02 March 2007 12:28, Kris Kennaway wrote: > >> On Fri, Mar 02, 2007 at 10:13:54AM -0700, Scott Long wrote: > >>> John Baldwin wrote: > >>>> jhb 2007-03-02 17:01:45 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: > >>>> sys/kern kern_intr.c > >>>> Log: > >>>> - Don't do the interrupt storm protection stuff for software interrupt > >>>> handlers. > >>>> - Use pause() when throtting during an interrupt storm. > >>>> > >>>> Reported by: kris (1) > >>>> > >>>> Revision Changes Path > >>>> 1.142 +3 -2 src/sys/kern/kern_intr.c > >>> Actually, having this helped detect a problem with a CAM driver. > >>> > >>> Scott > >> I saw it under normal operation when doing a lot of loopback traffic > >> on an 8-core. > > > > Also, if it ever kicked in for softclock, the system would deadlock. > > > > Can it be selectively enabled? We could do that, sure. The original intent was to prevent a storming level-triggered PCI interrupt to hang the machine though. It was never really intended for swi's and having it be on for swi's was an oversight on my part. -- John Baldwin