From owner-svn-ports-head@freebsd.org Thu Feb 7 11:14:43 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBE0A14D5C8A; Thu, 7 Feb 2019 11:14:42 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 75A5E84A1A; Thu, 7 Feb 2019 11:14:42 +0000 (UTC) (envelope-from tobik@freebsd.org) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9F6222298D; Thu, 7 Feb 2019 06:14:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 07 Feb 2019 06:14:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=za3Z4G IdvC4AoYBP7VGjPvBJibZUJcbTzUgbuipV3RQ=; b=2nVLVAIBPKr+VvT1xSICwX JjaOBiVaV9/NpuY8pJOM6WN8NF+EN8JkfFoBdgoVE8dqLt2I6ENAmBhbuNu7fWf8 PkItT42IARLCP4gqowHbUMxrHxMLOKD+WtEoGIVUpZygnxIoL5Rb9YjzPX3ME6GO yGJFVQ4LPu5hLYOk7+DDu3brI0Whv0+g/3b+aMpuZmq4iakLwsqVhZ4IYYUcdQR2 wkcARb5eCyZQrHosUF+022FyECKoZaN+sk/fhmoOwT0hYnI3RaXZHc/qEf+bI1Dr OAf6NNzUdYvAvu4BL1XzQWFaAM+RAtY/CaNGYI/XoqvZ9CVp9IUMW0ltbE+MhaRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrledtgddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgg gtuggjfgesghdtreertdervdenucfhrhhomhepvfhosghirghsucfmohhrthhkrghmphcu oehtohgsihhksehfrhgvvggsshgurdhorhhgqeenucffohhmrghinhepfhhrvggvsghsug drohhrghdpohhpthhiohhnshdrmhhknecukfhppeefuddrudejrddvhedurddvieenucfr rghrrghmpehmrghilhhfrhhomhepthhosghikhesfhhrvggvsghsugdrohhrghenucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from urd.tobik.me (ip1f11fb1a.dynamic.kabel-deutschland.de [31.17.251.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 12BBD1030F; Thu, 7 Feb 2019 06:14:30 -0500 (EST) Date: Thu, 7 Feb 2019 12:14:31 +0100 From: Tobias Kortkamp To: Rodrigo Osorio Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r492359 - head/graphics/ufraw Message-ID: <20190207111431.GA66860@urd.tobik.me> References: <201902071102.x17B2ksi050848@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="45Z9DzgjV8m4Oswq" Content-Disposition: inline In-Reply-To: <201902071102.x17B2ksi050848@repo.freebsd.org> User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 75A5E84A1A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Feb 2019 11:14:43 -0000 --45Z9DzgjV8m4Oswq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 7, 2019, at 12:02, Rodrigo Osorio wrote: > Author: rodrigo > Date: Thu Feb 7 11:02:46 2019 > New Revision: 492359 > URL: https://svnweb.freebsd.org/changeset/ports/492359 >=20 > Log: > Be able to build ufraw without GTK2 option > =20 > Add gnome to the uses to make testport happy > Bump portrevision > =20 > PR: 234436 > Reported by: Thomas Guymer >=20 > Modified: > head/graphics/ufraw/Makefile > head/graphics/ufraw/pkg-plist >=20 > Modified: head/graphics/ufraw/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/graphics/ufraw/Makefile Thu Feb 7 10:55:09 2019 (r492358) > +++ head/graphics/ufraw/Makefile Thu Feb 7 11:02:46 2019 (r492359) > @@ -3,7 +3,7 @@ > =20 > PORTNAME=3D ufraw > PORTVERSION=3D 0.22 > -PORTREVISION=3D 8 > +PORTREVISION=3D 9 > CATEGORIES=3D graphics > =20 > MAINTAINER=3D rodrigo@FreeBSD.org > @@ -20,7 +20,7 @@ LIB_DEPENDS=3D libtiff.so:graphics/tiff \ > =20 > GNU_CONFIGURE=3D yes > CONFIGURE_ARGS=3D --enable-extras > -USES=3D compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf > +USES=3D compiler:c++11-lang gettext gmake jpeg pkgconfig autoreconf gno= me > =20 > CPPFLAGS+=3D -I${LOCALBASE}/include > LDFLAGS+=3D -lpthread -L${LOCALBASE}/lib > @@ -58,6 +58,13 @@ GTK2_CONFIGURE_WITH=3D gtk > GNOME_USE=3D GNOME=3Dgconf2 > GNOME_CONFIGURE_ENABLE=3D mime > GNOME_VARS=3D CATEGORIES+=3Dgnome GCONF_SCHEMAS=3D${PORTNAME}.schemas > + > +.include > +.if ${PORT_OPTIONS:MGTK2} > +PLIST_SUB+=3D NOGTK2=3D"" > +.else > +PLIST_SUB+=3D NOGTK2=3D"@comment " > +.endif Naming it NOGTK2 is very confusing. OPTIONS_SUB=3Dyes already adds something like this just named after the option directly. Why not just use %%GTK2%% in pkg-plist to achieve the same thing? --45Z9DzgjV8m4Oswq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlxcExJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FM+gf/a3CEqRMQy2MaoomVEIqG6kC80eLvHVPBbpioVUes4G0DDTVuWjS6kgZu bLYcPHBdAT51Uqkq1+UhKZLfOfc6XiL9OSizARjvhSMjhRemBqFTSV604ipvc1Ca 9zPGZxgcDJm/+favp+hgM5QGkg1osHy1wdqLiLMnQYxMN52qqQRE+XegMNRBo/29 VMPUglKZYrBgYScfpjs/R99/NVBEZPF9+0QYWV/Oxip7tqimVLg/Q7twQKZ3Peyh 9aWwZIK4+deydKHTwygfvk7EA/y9uGD+UAD9i1wLOzjn/0OE1Ij5CBjeu7mxZxOA MQyC5VsO1jptHdOHFrvaL+N8275tNg== =9FiR -----END PGP SIGNATURE----- --45Z9DzgjV8m4Oswq--