From owner-cvs-all Sun Sep 29 23: 3:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D05C237B401; Sun, 29 Sep 2002 23:03:56 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 372A543E3B; Sun, 29 Sep 2002 23:03:55 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA07950; Mon, 30 Sep 2002 16:03:51 +1000 Date: Mon, 30 Sep 2002 16:12:58 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: "David E. O'Brien" Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/dev/aic7xxx/aicasm aicasm_symbol.c In-Reply-To: <200209300247.g8U2lNAA078034@freefall.freebsd.org> Message-ID: <20020930155132.O44572-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 29 Sep 2002, David E. O'Brien wrote: > obrien 2002/09/29 19:47:23 PDT > > Modified files: > sys/dev/aic7xxx/aicasm aicasm_symbol.c > Log: > Use fcntl.h from inside /sys. > > Reviewd by: scottl > > Revision Changes Path > 1.21 +1 -1 src/sys/dev/aic7xxx/aicasm/aicasm_symbol.c This is sort of backwards. aicasm runs on the host, so it should include only host headers. Howver, the change should be only a style bug in practice, since fcntl.h is a link to sys/fcntl.h and there shouldn't be any -I paths to /sys in the build of aicasm. There seems to be a problem only with the directory: there is a -I path to the kernel build directory and that directory has a machine symlink in it, so aicasm is built with an inconsistent set of includes in kernels. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message