Date: 19 May 2000 11:28:57 +0200 From: Dag-Erling Smorgrav <des@flood.ping.uio.no> To: Hajimu UMEMOTO (=?iso-2022-jp?b?GyRCR19LXBsoQiAbJEJIJRsoQg==?=) <ume@mahoroba.org> Cc: arch@freebsd.org Subject: Re: fetch(1) Message-ID: <xzpbt22horq.fsf@flood.ping.uio.no> In-Reply-To: Hajimu UMEMOTO's message of "Wed, 17 May 2000 05:01:37 %2B0900 (JST)" References: <200005122016.e4CKGtF38185@peace.mahoroba.org> <xzpog68i71b.fsf@flood.ping.uio.no> <200005161852.e4GIqhF74521@peace.mahoroba.org> <200005162001.e4GK1bF75342@peace.mahoroba.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hajimu UMEMOTO (梅本 肇) <ume@mahoroba.org> writes:
> One more.
> Fetch to ftp.openbsd.org fails with `999 Protocol error'.
> Ftp.openbsd.org seems to return '230 ' without any trailing message.
> [debugging output and patch deleted]
Actually, the correct fix is:
Index: ftp.c
===================================================================
RCS file: /home/ncvs/src/lib/libfetch/ftp.c,v
retrieving revision 1.19
diff -u -r1.19 ftp.c
--- ftp.c 2000/05/15 08:24:58 1.19
+++ ftp.c 2000/05/19 09:25:59
@@ -100,7 +100,8 @@
static int last_code;
#define isftpreply(foo) (isdigit(foo[0]) && isdigit(foo[1]) \
- && isdigit(foo[2]) && foo[3] == ' ')
+ && isdigit(foo[2]) \
+ && (foo[3] == ' ' || foo[3] == '\0'))
#define isftpinfo(foo) (isdigit(foo[0]) && isdigit(foo[1]) \
&& isdigit(foo[2]) && foo[3] == '-')
There are some places in ftp.c (e.g. the passive ftp code) that assume
there is text after the status code; I'll see what I can do to fix them.
DES
--
Dag-Erling Smorgrav - des@flood.ping.uio.no
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpbt22horq.fsf>