From owner-svn-ports-all@freebsd.org Wed Oct 14 12:45:28 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B3A1B43835D; Wed, 14 Oct 2020 12:45:28 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CBBw84PBDz3fsk; Wed, 14 Oct 2020 12:45:28 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 5FEDD21809; Wed, 14 Oct 2020 12:45:28 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id E2CBCE6FC0; Wed, 14 Oct 2020 14:45:23 +0200 (CEST) Date: Wed, 14 Oct 2020 14:45:23 +0200 From: Baptiste Daroussin To: Mathieu Arnold Cc: Renato Botelho , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r552232 - head/devel/git Message-ID: <20201014124523.jgqcp76lqinqkcho@ivaldir.net> References: <202010131132.09DBWRIZ099906@repo.freebsd.org> <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5g46yn4g2kpbecxo" Content-Disposition: inline In-Reply-To: <20201014115047.omi53rjydfvoabyk@aching.in.mat.cc> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 12:45:28 -0000 --5g46yn4g2kpbecxo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2020 at 01:50:47PM +0200, Mathieu Arnold wrote: > On Tue, Oct 13, 2020 at 11:32:27AM +0000, Renato Botelho wrote: > > Author: garga > > Date: Tue Oct 13 11:32:26 2020 > > New Revision: 552232 > > URL: https://svnweb.freebsd.org/changeset/ports/552232 > >=20 > > Log: > > Simplify logic to define COMMENT > > =20 > > Submitted by: bapt > >=20 > > Modified: > > head/devel/git/Makefile > >=20 > > Modified: head/devel/git/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/devel/git/Makefile Tue Oct 13 11:30:50 2020 (r552231) > > +++ head/devel/git/Makefile Tue Oct 13 11:32:26 2020 (r552232) > > @@ -12,12 +12,11 @@ EXTRACT_ONLY=3D ${DISTNAME}${EXTRACT_SUFX} \ > > ${PORTNAME}-manpages-${DISTVERSION}${EXTRACT_SUFX} > > =20 > > MAINTAINER=3D garga@FreeBSD.org > > -.if ${FLAVOR:Udefault} =3D=3D default > > COMMENT=3D Distributed source code management tool > > -.elif ${FLAVOR:U} =3D=3D gui > > -COMMENT=3D Distributed source code management tool (GUI enabled flavor) > > +.if ${FLAVOR:U} =3D=3D gui > > +COMMENT+=3D (GUI enabled flavor) > > .elif ${FLAVOR:U} =3D=3D lite > > -COMMENT=3D Distributed source code management tool (lite flavor) > > +COMMENT+=3D (lite flavor) > > .endif >=20 > If one really wanted to make it clear and simple, one could even write: >=20 > COMMENT=3D Distributed source code management tool ${COMMENT_${FLAVOR}} > COMMENT_gui=3D (GUI enabled flavor) > COMMENT_lite=3D (lite flavor) Hey nice one! I like it Best regards, Bapt --5g46yn4g2kpbecxo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl+G8t8ACgkQY4mL3PG3 PlozMhAAj8ctA8EoheKpm8I6QbyJTCLh8yeTAx6MG9b/mwm8VbgSlYmZIhv0E7eO LDFuPCit5bYaUYIeXQc5YSHd13ozl7frsMbNZLPyi5T9kTqxeI3yn5MXqMhzlyYi TKZBFy2ZOLY5Ms5sbz07QOohlbJ0Fzksw5xZjd6WxwfjI7q+ABBUzcth762zkRue lcJxUjrgxix5RWJPF0y2TNw2CsGAfsppPfkPQaTYriQPyqo/yaO6geH+QN5p7qR8 nuTPGK5ik5XeI7PC8+mLDVcbmz8QMiYg7ds8l53gjU0NwPbxyQCV+4SE8qTxw1Us uN6tHgcJOlUPME84NOgwDm9OAwkF9ubNzGZa/VD3CJgNZe41Nfv3PnTJCr6XO7Vn gPwLxnKdI8EDF5tXE4xz0XbMC6HSwJI/0EKDZaZGO27RYCtSAOKm6G9bZ6L8pBYo +vr9ULK+ncD8C4vPtBEkDGn2K8STxT3L5xiwuxXI0m+JIZ1lOXEJqzStNSHIE3ED McsihGvgVKBTI1tqddapHn7I7VsXb7iBdJVspLPZ36uld3AgGI0ISDSY4tHqLznb aDvIcihqBvSC1j9DxSWBnvLnjTwbL8vQ7QdlsiiJL4aVq9c8fYHeOpGHNOOC5tFs LasXBLF7IgYPkBtBaLc9cpQ3m1LY0XnCHBdDVQlvO8b+ILhq/A0= =xbuR -----END PGP SIGNATURE----- --5g46yn4g2kpbecxo--