From nobody Fri Jun 26 14:40:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gmyy90fCKz6jbfv for ; Fri, 26 Jun 2026 14:40:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gmyy84zkMz3Wr5 for ; Fri, 26 Jun 2026 14:40:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782484816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VOQ98AqiAKvI1yUngWrnc4/n5SfhR1oEKiZr/KWMZZE=; b=t2izCR3q9GRHngzwczifNOLti4yNUzy2gsr7sM387cblS30Nf+mDQDGFsaGBvwgp7Qik9Y mSu+5718ob0Anu2j5ga7drUa0A+yR301qFz4PORDHrUN+5xNa2MwQKzPbLan1T6ffcFrh1 uZgnOnkP4XMUWhNl5oNgJ+WLGojIPZSACi+sGrRR2Kzt7HRXZM1TVhCQquPWd6V4V/1l50 jr8Q0MSvUy+mzrreYSipwLlA5TxhkfFqA20DRPU7H8cK5kxH0PUzr7Gpd1D96b9Ms1tIf+ iITub0xQxNG2RJiMBkVbq1cCdcJLSTc2U70+ffuI8jodfbd13SlBrM+vz/rwag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782484816; a=rsa-sha256; cv=none; b=NPw8KA4p2RB5YiaFfTKpkjzDJiqx4LHwLj6ZKoOcYPvoPhrAWhnCnGmT0QTCbbkF+BuRQk etYMtOTKNycXhJtUcXyfP7Ug8kr7jnjWg/Ds1DLwLG79+NR5V0WMEXlXKUo1MX0nx/vQ61 LuLOj132obzlWGnU1kW45E8oy+4GNSwq4e80+MNlBkf8VK/mPFWjUtYb6G6MisKhsv9jpw dXe/PDyRSmtwBcby28roKi9V6RNGuwiqO+CfHTyQE2THIekF22N1b8Hcp1tTYRNsGqzf7s BnCNq2qIc8g0vi1my0iELFqH/QFKChcQkhZ77r7hrJshKz5W+HqSZ1JPL0J69A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782484816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VOQ98AqiAKvI1yUngWrnc4/n5SfhR1oEKiZr/KWMZZE=; b=a8gWVDE+bKJIf7aEOS1QGVqoyHNqsQaBuTB7SLyKVLwSqnmaJ36uxDhDw8jVbBxwwtntNX kqxKaMpkDLT7MKNBjVqJmK6sfsj0w7CeAwhwmbfGMgivCFTIZ/luFbNNKTZzMoUkt4gZay AiOuhbS9bBKQYynl+KgZQ1cGmLsx6OVq578i0bjPsF/oBvcN4UQUQmUWGDl7Lm9ZJFZ/QF AJlcto0D/XAeZKz6t6/g9cRLw2nKV5cx+RrxB3iaI6INrLypiDvaaaIoHwuJvE/p66euz4 b+uYlvYFayh+hdSgG6R6fCib0DRgbqj/9rZcTbUtcVpO6FWc+pVox44Cjj1mkw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gmyy844RjzhKS for ; Fri, 26 Jun 2026 14:40:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1e25a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 14:40:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: b0d3a2889a1b - main - rc.d/ddb: Really silently exit List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b0d3a2889a1b8e4b73ad1f396884224e1442b214 Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 14:40:16 +0000 Message-Id: <6a3e8f50.1e25a.4aafc013@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=b0d3a2889a1b8e4b73ad1f396884224e1442b214 commit b0d3a2889a1b8e4b73ad1f396884224e1442b214 Author: Dag-Erling Smørgrav AuthorDate: 2026-06-26 14:38:58 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-06-26 14:38:58 +0000 rc.d/ddb: Really silently exit The comment says “silently exit if ddb is not enabled”, but we'd exit with an error message. Note that I switched the sysctl variable used to test for the presence of ddb from debug.ddb.scripting.scripts to d.d.s.script, which has a smaller value if set. While here, drop a pointless fork-exec, and use ${SYSCTL_N} for consistency. PR: 177217 MFC after: 1 week Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D57686 --- libexec/rc/rc.d/ddb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libexec/rc/rc.d/ddb b/libexec/rc/rc.d/ddb index 08a7d345c326..a30df2dc1c5e 100755 --- a/libexec/rc/rc.d/ddb +++ b/libexec/rc/rc.d/ddb @@ -20,8 +20,8 @@ stop_cmd=":" ddb_prestart() { # Silently exit if ddb is not enabled - if [ -z "`sysctl -Nq debug.ddb.scripting.scripts`" ]; then - return 1 + if ! ${SYSCTL_N} -q debug.ddb.scripting.script >/dev/null; then + exit 1 fi }