From owner-p4-projects@FreeBSD.ORG Mon Jan 16 00:15:20 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E5C2216A422; Mon, 16 Jan 2006 00:15:19 +0000 (GMT) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEED116A41F for ; Mon, 16 Jan 2006 00:15:19 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 814EA43D45 for ; Mon, 16 Jan 2006 00:15:19 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k0G0FJDF032149 for ; Mon, 16 Jan 2006 00:15:19 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k0G0FJ7h032146 for perforce@freebsd.org; Mon, 16 Jan 2006 00:15:19 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Mon, 16 Jan 2006 00:15:19 GMT Message-Id: <200601160015.k0G0FJ7h032146@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 89768 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2006 00:15:20 -0000 http://perforce.freebsd.org/chv.cgi?CH=89768 Change 89768 by rwatson@rwatson_peppercorn on 2006/01/16 00:14:19 When aborting audit_write_failure_self() due to trying circumstances, make sure to release the subject token rather than leaking it. Found by: Coverity Prevent (tm) Affected files ... .. //depot/projects/trustedbsd/openbsm/libbsm/bsm_wrappers.c#10 edit Differences ... ==== //depot/projects/trustedbsd/openbsm/libbsm/bsm_wrappers.c#10 (text+ko) ==== @@ -265,6 +265,7 @@ } /* tokenize and save the error message */ if ((errtok = au_to_text(errmsg)) == NULL) { + au_free_token(subject); syslog(LOG_ERR, "%s: au_to_text() failed", func); return (kAUMakeTextTokErr); }