From owner-svn-src-stable@FreeBSD.ORG Wed Dec 11 23:06:04 2013 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EC7DD1E; Wed, 11 Dec 2013 23:06:04 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5A1F211F5; Wed, 11 Dec 2013 23:06:04 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rBBN643M095396; Wed, 11 Dec 2013 23:06:04 GMT (envelope-from dumbbell@svn.freebsd.org) Received: (from dumbbell@localhost) by svn.freebsd.org (8.14.7/8.14.7/Submit) id rBBN64HJ095395; Wed, 11 Dec 2013 23:06:04 GMT (envelope-from dumbbell@svn.freebsd.org) Message-Id: <201312112306.rBBN64HJ095395@svn.freebsd.org> From: Jean-Sebastien Pedron Date: Wed, 11 Dec 2013 23:06:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: svn commit: r259236 - stable/10/sys/dev/drm2/radeon X-SVN-Group: stable-10 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Dec 2013 23:06:04 -0000 Author: dumbbell Date: Wed Dec 11 23:06:03 2013 New Revision: 259236 URL: http://svnweb.freebsd.org/changeset/base/259236 Log: MFC r259104: drm/radeon: radeon_dp_i2c_aux_ch() must return 0 on FreeBSD The code was unmodified compared to Linux and returned the amount of received bytes from the i2c bus. This led to non-working i2c bus and failure to eg. read monitor's EDID, if connected to DisplayPort. Tested by: Mikaƫl Urankar Modified: stable/10/sys/dev/drm2/radeon/atombios_dp.c Directory Properties: stable/10/ (props changed) Modified: stable/10/sys/dev/drm2/radeon/atombios_dp.c ============================================================================== --- stable/10/sys/dev/drm2/radeon/atombios_dp.c Wed Dec 11 22:36:20 2013 (r259235) +++ stable/10/sys/dev/drm2/radeon/atombios_dp.c Wed Dec 11 23:06:03 2013 (r259236) @@ -272,7 +272,7 @@ int radeon_dp_i2c_aux_ch(device_t dev, i case AUX_I2C_REPLY_ACK: if (mode == MODE_I2C_READ) *read_byte = reply[0]; - return ret; + return (0); /* Return ret on Linux. */ case AUX_I2C_REPLY_NACK: DRM_DEBUG_KMS("aux_i2c nack\n"); return -EREMOTEIO;